linux-kernel - Re: [PATCH] watchdog: da9052

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5pErC3d7AqTq3z9@gmail.com>
Date: Wed, 29 Jan 2025 16:09:32 +0100
From: Marcus Folkesson <marcus.folkesson@...il.com>
To: Guenter Roeck <linux@...ck-us.net>
Cc: Support Opensource <support.opensource@...semi.com>,
	Wim Van Sebroeck <wim@...ux-watchdog.org>,
	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marcus Folkesson <marcus.folkesson@...bitech.com>
Subject: Re: [PATCH] watchdog: da9052_wdt: respect TWDMIN

Hello,

On Wed, Jan 29, 2025 at 06:48:04AM -0800, Guenter Roeck wrote:
> On 1/29/25 01:24, Marcus Folkesson wrote:
> > From: Marcus Folkesson <marcus.folkesson@...bitech.com>
> > 
> > We have to wait at least the minimium time for the watchdog window
> > (TWDMIN) before writings to the wdt register after the
> > watchdog is activated.
> > Otherwise the chip will assert TWD_ERROR and power down to reset mode.
> > 
> 
> This is missing a key explanation:
> 
> Why does setting @min_hw_heartbeat_ms in struct watchdog_device
> not work for this driver ?

Thank you Guenter, I wasn't aware of min_hw_heartbeat_ms. I will see
if it helps.

I've also noticed that the same problem occur when, for example, I set
the timeout with wdctl and .stop is called too soon as the application
terminates.

> 
> Guenter
> 

Best regards,
Marcus Folkesson

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)