linux-kernel - Re: [PATCH 0/2] lib/crc: simplify choice of CRC implementations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXFYH39XzAo2D9toZdWm=tTABNBzt=TV_coo-NjPaHNuVA@mail.gmail.com>
Date: Wed, 29 Jan 2025 17:11:57 +0100
From: Ard Biesheuvel <ardb@...nel.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, 
	Chao Yu <chao@...nel.org>, "Darrick J . Wong" <djwong@...nel.org>, 
	Geert Uytterhoeven <geert@...ux-m68k.org>, Kent Overstreet <kent.overstreet@...ux.dev>, 
	"Martin K . Petersen" <martin.petersen@...cle.com>, Michael Ellerman <mpe@...erman.id.au>, 
	"Theodore Ts'o" <tytso@....edu>, Vinicius Peixoto <vpeixoto@...amp.dev>, WangYuli <wangyuli@...ontech.com>, 
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 0/2] lib/crc: simplify choice of CRC implementations

On Sat, 25 Jan 2025 at 01:37, Eric Biggers <ebiggers@...nel.org> wrote:
>
> On Thu, Jan 23, 2025 at 01:29:02PM -0800, Eric Biggers wrote:
> > This series simplifies the choice of CRC implementations, as requested
> > by Linus at
> > https://lore.kernel.org/linux-crypto/CAHk-=wgqAZf7Sdyrka5RQQ2MVC1V_C1Gp68KrN=mHjPiRw70Jg@mail.gmail.com/
> >
> > Eric Biggers (2):
> >   lib/crc: simplify the kconfig options for CRC implementations
> >   lib/crc32: remove other generic implementations
> >
> >  lib/Kconfig          | 118 +++--------------------
> >  lib/crc32.c          | 225 ++-----------------------------------------
> >  lib/crc32defs.h      |  59 ------------
> >  lib/gen_crc32table.c | 113 ++++++----------------
> >  4 files changed, 53 insertions(+), 462 deletions(-)
> >  delete mode 100644 lib/crc32defs.h
>
> FYI, I am tentatively planning a pull request next week with this, and this is
> now in linux-next (via my crc-next tree).  Reviews / acks appreciated!
>

For the series,

Reviewed-by: Ard Biesheuvel <ardb@...nel.org>