linux-kernel - [PATCH 0/3] kdb: Delete never used KGDB NMI code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250129162700.848018-1-dianders@chromium.org>
Date: Wed, 29 Jan 2025 08:25:49 -0800
From: Douglas Anderson <dianders@...omium.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Daniel Thompson <danielt@...nel.org>
Cc: "Dr . David Alan Gilbert" <linux@...blig.org>,
	kgdb-bugreport@...ts.sourceforge.net,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Sumit Garg <sumit.garg@...aro.org>,
	linux-serial@...r.kernel.org,
	Douglas Anderson <dianders@...omium.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Arnd Bergmann <arnd@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Hugo Villeneuve <hvilleneuve@...onoff.com>,
	Jason Wessel <jason.wessel@...driver.com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Nir Lichtman <nir@...htman.org>,
	Robert Marko <robert.marko@...tura.hr>,
	Thorsten Blum <thorsten.blum@...ux.dev>,
	Yuran Pereira <yuran.pereira@...mail.com>,
	Zheng Zengkai <zhengzengkai@...wei.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH 0/3] kdb: Delete never used KGDB NMI code

As pointed out in the review [1] of commit 39d0be87438a ("serial:
kgdb_nmi: Remove unused knock code"), it's not just the knock code
that's unused but a whole chunk of NMI-related code in KGDB.

Look back at the original series [2] and revert a few of the patches
that managed to land and had no other purpose. They've been in the
kernel for over 12 years and if nobody has used them during that time
then they won't get used.

I've validated things still compile just fine for me and I've tested
"allmodconfig" for a few different architectures. Hopefully I didn't
miss anything, but based on "grep" this is all just dead code.

I guess I'd expect this to land through Greg KH's tree, ideally Acked
by Daniel Thompson.

[1] https://lore.kernel.org/r/CAD=FV=VH5YWfTggGNt2KLoSPKqVTmWArEgccok3uFQ5BCA7cNw@mail.gmail.com
[2] https://lore.kernel.org/lkml/1348522080-32629-9-git-send-email-anton.vorontsov@linaro.org/


Douglas Anderson (3):
  Revert "tty/serial: Add kgdb_nmi driver"
  Revert "kdb: Implement disable_nmi command"
  Revert "kernel/debug: Mask KGDB NMI upon entry"

 drivers/tty/serial/Kconfig    |  19 ---
 drivers/tty/serial/Makefile   |   1 -
 drivers/tty/serial/kgdb_nmi.c | 280 ----------------------------------
 drivers/tty/serial/kgdboc.c   |   8 -
 include/linux/kgdb.h          |  11 --
 kernel/debug/debug_core.c     |  14 +-
 kernel/debug/kdb/kdb_main.c   |  37 -----
 7 files changed, 3 insertions(+), 367 deletions(-)
 delete mode 100644 drivers/tty/serial/kgdb_nmi.c

-- 
2.48.1.262.g85cc9f2d1e-goog