linux-kernel - Re: [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment for cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f9aa4253-2ba9-4a0d-a456-a580cd3bad6b@redhat.com>
Date: Wed, 29 Jan 2025 17:36:23 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Lee Jones <lee@...nel.org>, linux-kernel@...r.kernel.org
Cc: Andy Shevchenko <andy@...nel.org>
Subject: Re: [PATCH v1 1/1] mfd: intel_soc_pmic_crc: Drop unneeded assignment
 for cache_type

Hi,

On 29-Jan-25 4:28 PM, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
> 
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>  drivers/mfd/intel_soc_pmic_crc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index 879fbf5cd162..41429f9bcb69 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -113,7 +113,6 @@ static const struct regmap_config crystal_cove_regmap_config = {
>  	.val_bits = 8,
>  
>  	.max_register = CRYSTAL_COVE_MAX_REGISTER,
> -	.cache_type = REGCACHE_NONE,
>  };
>  
>  static const struct regmap_irq crystal_cove_irqs[] = {