linux-kernel - Re: [PATCH v3 08/10] drm/display: bridge-connector: handle CEC adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c676ef1a-3b08-4342-b4da-d0b525f2f55b@linaro.org>
Date: Wed, 29 Jan 2025 17:44:31 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Maxime Ripard <mripard@...nel.org>
Cc: Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Maíra Canal <mcanal@...lia.com>,
 Raspberry Pi Kernel Maintenance <kernel-list@...pberrypi.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 08/10] drm/display: bridge-connector: handle CEC
 adapters

On 29/01/2025 00:44, Dmitry Baryshkov wrote:
> On Tue, Jan 28, 2025 at 05:14:06PM +0100, Maxime Ripard wrote:
>> On Sun, Jan 26, 2025 at 03:29:13PM +0200, Dmitry Baryshkov wrote:
>>>   /* -----------------------------------------------------------------------------
>>>    * Bridge Connector Initialisation
>>>    */
>>> @@ -633,6 +711,21 @@ struct drm_connector *drm_bridge_connector_init(struct drm_device *drm,
>>>   			if (ret)
>>>   				return ERR_PTR(ret);
>>>   		}
>>> +
>>> +		if (bridge->hdmi_cec_adapter_name) {
>>> +			if (!bridge->funcs->hdmi_cec_enable ||
>>> +			    !bridge->funcs->hdmi_cec_log_addr ||
>>> +			    !bridge->funcs->hdmi_cec_transmit)
>>> +				return ERR_PTR(-EINVAL);
>>> +
>>> +			ret = drm_connector_hdmi_cec_register(connector,
>>> +							      &drm_bridge_connector_hdmi_cec_ops,
>>> +							      bridge->hdmi_cec_adapter_name,
>>> +							      bridge->hdmi_cec_available_las,
>>> +							      bridge->hdmi_dev);
>>> +			if (ret)
>>> +				return ERR_PTR(ret);
>>> +		}
>>
>> Maybe we can use a different bridge feature flag to trigger the CEC code
>> support instead?
> 
> it is possible, but what is the possible usecase? DP drivers should be
> using DP_AUX CEC instead. And I think there are no other kinds of
> bridges which implement CEC support. Meson driver does something strange
> by registering CEC notifier from meson_encoder_hdmi. I think instead
> this should be moved to the DW HDMI bridge itself
> 

It was done before bridge_connector has any support for CEC to keep the
functionnality, I'll be happy to switch to this.

Neil