linux-kernel - Re: [PATCH v3] of: address: Add kunit test for __of_address_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <173816930010.2216376.7589401365931628062.robh@kernel.org>
Date: Wed, 29 Jan 2025 10:48:22 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Cc: Basharath Hussain Khaja <basharath@...thit.com>,
	Saravana Kannan <saravanak@...gle.com>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] of: address: Add kunit test for
 __of_address_resource_bounds()


On Wed, 29 Jan 2025 14:35:27 +0100, Thomas Weißschuh wrote:
> The overflow checking has to deal with different datatypes and
> edgecases. Add a new kunit testcase to make sure it works correctly.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
> ---
> Changes in v3:
> - Avoid constant truncation warnings by using u64 for test case
>   expectations
> - Run through 0day before submission
> - Link to v2: https://lore.kernel.org/r/20250127-of-address-overflow-v2-1-61b5046044e9@linutronix.de
> 
> Changes in v2:
> - Rebase on robh/for-master
> - Drop already applied patch
> - Add missing MODULE_IMPORT_NS()
> - Fix sparse warnings: "cast truncates bits from constant value"
> - Link to v1: https://lore.kernel.org/r/20250120-of-address-overflow-v1-0-dd68dbf47bce@linutronix.de
> ---
> Technically it's possible to run this unittest with !CONFIG_OF_ADDRESS,
> so there is an explicit check inside the test.
> It would also be possible to add a dedicated source file, but that
> seemed like a lot of churn to me.
> ---
>  drivers/of/address.c    |   5 +-
>  drivers/of/of_private.h |   4 ++
>  drivers/of/of_test.c    | 119 +++++++++++++++++++++++++++++++++++++++++++++++-
>  3 files changed, 126 insertions(+), 2 deletions(-)
> 

Applied, thanks!