linux-kernel - Re: [PATCH 2/3] pinctrl: samsung: add dedicated SoC eint suspend/resume callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de0d9a23-7364-4d33-81bc-05847a3b4ff6@kernel.org>
Date: Wed, 29 Jan 2025 18:53:16 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Griffin <peter.griffin@...aro.org>,
 André Draszik <andre.draszik@...aro.org>
Cc: Sylwester Nawrocki <s.nawrocki@...sung.com>,
 Alim Akhtar <alim.akhtar@...sung.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 linux-arm-kernel@...ts.infradead.org, linux-samsung-soc@...r.kernel.org,
 linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
 tudor.ambarus@...aro.org, willmcvicker@...gle.com,
 semen.protsenko@...aro.org, kernel-team@...roid.com, jaewon02.kim@...sung.com
Subject: Re: [PATCH 2/3] pinctrl: samsung: add dedicated SoC eint
 suspend/resume callbacks

On 21/01/2025 15:46, Peter Griffin wrote:
>>> and eint_mask_offset for saving & restoring it's registers.
>>>
>>> Refactor the existing platform specific suspend/resume callback
>>> so that each SoC variant has their own callback containing the
>>> SoC specific logic.
>>>
>>> Additionally we now call drvdata->suspend() & drvdata->resume()
>>> from within the loop that iterates the banks in
>>> samsung_pinctrl_suspend() and samsung_pinctrl_resume().
>>
>> Maybe split this patch in two:
>> * first to do the refactoring plus adding exynosautov920_pinctrl_suspend()
>>   and exynosautov920_pinctrl_resume()
>> * second to add gs101_pinctrl_suspend() / gs101_pinctrl_resume()
>>
>> This way, it's obvious which part is the bugfix and which part is the
>> preparation and I believe it'd be easier to read.
> 
> Sure, I will split it into two patches in the next version.
> 
Yeah, ack.

Best regards,
Krzysztof