linux-kernel - Re: [PATCH v2] hwmom/applesmc: add imacpro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7D2F2DB0-E94C-4372-9285-A91C4C856934@live.com>
Date: Wed, 29 Jan 2025 18:22:59 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Guenter Roeck <linux@...ck-us.net>
CC: Atharva Tiwari <evepolonium@...il.com>, Henrik Rydberg
	<rydberg@...math.org>, Jean Delvare <jdelvare@...e.com>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Orlando
 Chamberlain <orlandoch.dev@...il.com>
Subject: Re: [PATCH v2] hwmom/applesmc: add imacpro

Hi Guenter

Sorry to barge in like that but I have some issues with this here.

1. The iMacPro1,1 is a T2 Mac and the applesmc driver does not support T2 Macs upstream, thus making no point of adding this. We at t2linux have downstream patches to support T2 Macs, but we do not aim to upstream them since we wish to use a separate, and better driver for the SMC on T2 Macs.

2. The person who submitted the patch took it from the t2linux project, of which I am a part of, but didn't care to even credit the original author of the patch. I’m not sure how legal it is to redistribute the code in his own name and removing the original author’s name without taking permission from the author as per the GPL2 license, but I think the author should be credited. In fact the original patch was Signed-off-by the original author.

For reference, the original patch, which we never intended to be sent upstream, is given over here:

https://github.com/t2linux/linux-t2-patches/blob/main/3007-applesmc-Add-iMacPro-to-applesmc_whitelist.patch

I leave the fate of this to you now.

Regards
Aditya

> On 29 Jan 2025, at 9:36 PM, Guenter Roeck <linux@...ck-us.net> wrote:
> 
> On Thu, Jan 23, 2025 at 05:47:28PM +0530, Atharva Tiwari wrote:
>> Add iMacPro to whitelist as one iMacPro is released.
>> The iMacPro 1,1
>> 
>> Signed-off-by: Atharva Tiwari <evepolonium@...il.com>
> 
> Applied to hwmon-next.
> 
> Note that the branch will only be pushed to linux-next after the commit
> window closed.
> 
> Thanks,
> Guenter
>