linux-kernel - Re: [PATCH v1 1/1] spi: realtek-rtl-snand: Drop unneeded assignment for cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a69fb7c-6c33-4df9-b3c2-3e3db74760d2@alliedtelesis.co.nz>
Date: Wed, 29 Jan 2025 19:40:58 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v1 1/1] spi: realtek-rtl-snand: Drop unneeded assignment
 for cache_type

Hi Andy,

On 30/01/2025 04:29, Andy Shevchenko wrote:
> REGCACHE_NONE is the default type of the cache when not provided.
> Drop unneeded explicit assignment to it.
>
> Note, it's defined to 0, and if ever be redefined, it will break
> literally a lot of the drivers, so it very unlikely to happen.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Reviewed-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

> ---
>   drivers/spi/spi-realtek-rtl-snand.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-realtek-rtl-snand.c b/drivers/spi/spi-realtek-rtl-snand.c
> index cd0484041147..741cf2af3e91 100644
> --- a/drivers/spi/spi-realtek-rtl-snand.c
> +++ b/drivers/spi/spi-realtek-rtl-snand.c
> @@ -364,7 +364,6 @@ static int rtl_snand_probe(struct platform_device *pdev)
>   		.reg_bits	= 32,
>   		.val_bits	= 32,
>   		.reg_stride	= 4,
> -		.cache_type	= REGCACHE_NONE,
>   	};
>   	int irq, ret;
>