linux-kernel - Re: [PATCH] scsi: core: Do not retry I/Os during depopulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5wQBzQIYH1iw6gQ@google.com>
Date: Thu, 30 Jan 2025 15:49:27 -0800
From: Igor Pylypiv <ipylypiv@...gle.com>
To: Bart Van Assche <bvanassche@....org>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Douglas Gilbert <dgilbert@...erlog.com>, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: core: Do not retry I/Os during depopulation

On Thu, Jan 30, 2025 at 02:36:35PM -0800, Bart Van Assche wrote:
> On 1/30/25 2:26 PM, Igor Pylypiv wrote:
> > Fail I/Os instead of retry to prevent user space processes from being
> > blocked on the I/O completion for several minutes.
> > 
> > Retrying I/Os during "depopulation in progress" or "depopulation restore
> > in progress" results in a continuous retry loop until the depopulation
> > completes or until the I/O retry loop is aborted due to a timeout by
> > the scsi_cmd_runtime_exceeced().
> > 
> > Depopulation is slow and can take 24+ hours to complete on 20+ TB HDDs.
> > Most I/Os in the depopulation retry loop end up taking several minutes
> > before returning the failure to user space.
> 
> Since this patch is a bug fix, please add Fixes: and Cc: stable tags.

Thank you, Bart. I'll add the following tags to v2:

    Cc: <stable@...r.kernel.org> # 4.18.x: 2bbeb8d scsi: core: Handle depopulation and restoration in progress"
    Cc: <stable@...r.kernel.org> # 4.18.x
    Fixes: e37c7d9a0341 ("scsi: core: sanitize++ in progress")

Thanks,
Igor

> 
> Thanks,
> 
> Bart.