linux-kernel - Re: [PATCH v5] hwmon: Add T2 Mac fan control support in applesmc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a77c0e83-8be0-4ad6-9900-a5e9d63c1323@roeck-us.net>
Date: Wed, 29 Jan 2025 21:15:46 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Atharva Tiwari <evepolonium@...il.com>
Cc: Aun-Ali Zaidi <admin@...eit.net>, Henrik Rydberg <rydberg@...math.org>,
	Jean Delvare <jdelvare@...e.com>, linux-kernel@...r.kernel.org,
	linux-hwmon@...r.kernel.org
Subject: Re: [PATCH v5] hwmon: Add T2 Mac fan control support in applesmc
 driver

On Tue, Jan 21, 2025 at 12:03:37AM +0530, Atharva Tiwari wrote:
> This patch adds support for fan control on T2 Macs in the applesmc driver.
> It introduces functions to handle floating-point fan speed values
> (which are required by t2 chips).
> The fan speed reading and writing are updated to
> support both integer and floating-point values.
> The fan manual control is also updated to handle T2 Mac-specific keys.
> 
> Guenter Roeck asked "Does this limit still apply?"
> so yes the limit still applies.
> 

I just learned that this series originates from [1], that it should
not be submitted on its own, and, worse, that it does not add T2 support
without other patches which have not been submitted.

As such, NACK for this patch. Please discuss with the t2 project if and
when the series should be submitted into the upstream kernel.

Guenter