linux-kernel - Re: [PATCH v5 3/5] arm64: dts: agilex: add dtsi for PCIe Root Port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <40a3dced-defe-412d-b5b2-efcc9619d172@kernel.org>
Date: Thu, 30 Jan 2025 08:26:07 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: matthew.gerlach@...ux.intel.com
Cc: lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org,
 robh@...nel.org, bhelgaas@...gle.com, krzk+dt@...nel.org,
 conor+dt@...nel.org, dinguyen@...nel.org, joyce.ooi@...el.com,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, matthew.gerlach@...era.com,
 peter.colberg@...era.com
Subject: Re: [PATCH v5 3/5] arm64: dts: agilex: add dtsi for PCIe Root Port

On 29/01/2025 20:42, matthew.gerlach@...ux.intel.com wrote:
> 
> 
> On Wed, 29 Jan 2025, Krzysztof Kozlowski wrote:
> 
>> On 27/01/2025 18:35, Matthew Gerlach wrote:
>>> Add the base device tree for support of the PCIe Root Port
>>> for the Agilex family of chips.
>>>
>>> Signed-off-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
>>> ---
>>> v3:
>>>  - Remove accepted patches from patch set.
>>>
>>> v2:
>>>  - Rename node to fix schema check error.
>>> ---
>>>  .../intel/socfpga_agilex_pcie_root_port.dtsi  | 55 +++++++++++++++++++
>>>  1 file changed, 55 insertions(+)
>>>  create mode 100644 arch/arm64/boot/dts/intel/socfpga_agilex_pcie_root_port.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_pcie_root_port.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex_pcie_root_port.dtsi
>>> new file mode 100644
>>> index 000000000000..50f131f5791b
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_pcie_root_port.dtsi
>>> @@ -0,0 +1,55 @@
>>> +// SPDX-License-Identifier:     GPL-2.0
>>
>> Odd spaces in SPDX tag.
> 
> Yes, there should only be one space.
> 
>>
>>> +/*
>>> + * Copyright (C) 2024, Intel Corporation
>>> + */
>>> +&soc0 {
>>> +	aglx_hps_bridges: fpga-bus@...00000 {
>>> +		compatible = "simple-bus";
>>> +		reg = <0x80000000 0x20200000>,
>>> +		      <0xf9000000 0x00100000>;
>>> +		reg-names = "axi_h2f", "axi_h2f_lw";
>>
>> Where is this binding defined?
> 
> The bindings for these reg-names are not currently defined anywhere, but 

Then you cannot use them.

> they are also referenced in the following:
>      Documentation/devicetree/bindings/soc/intel/intel,hps-copy-engine.yaml
>      arch/arm64/boot/dts/intel/socfpga_agilex_n6000.dts
> I am not exactly sure where the right place is to define them, maybe
> Documentation/devicetree/bindings/arm/intel,socfpga.yaml. On the other 
> hand, no code references these names; so it might make sense to just 
> remove them.

In general: nowhere, because simple bus does not have such properties.
It's not about reg-names only - you cannot have reg. You just did not
define here simple-bus.

Best regards,
Krzysztof