linux-kernel - Re: [PATCH v3 3/3] iommu/s390: implement iommu passthrough via identity domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53c930df7058288776392073964a70025ca62d19.camel@linux.ibm.com>
Date: Thu, 30 Jan 2025 08:43:38 +0100
From: Niklas Schnelle <schnelle@...ux.ibm.com>
To: Matthew Rosato <mjrosato@...ux.ibm.com>, joro@...tes.org, will@...nel.org,
        robin.murphy@....com, gerald.schaefer@...ux.ibm.com
Cc: hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        svens@...ux.ibm.com, borntraeger@...ux.ibm.com, farman@...ux.ibm.com,
        clegoate@...hat.com, iommu@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH v3 3/3] iommu/s390: implement iommu passthrough via
 identity domain

On Fri, 2025-01-24 at 15:17 -0500, Matthew Rosato wrote:
> Enabled via the kernel command-line 'iommu.passthrough=1' option.
> 
> Introduce the concept of identity domains to s390-iommu, which relies on
> the bus_dma_region to offset identity mappings to the start of the DMA
> aperture advertized by CLP.
> 
> Signed-off-by: Matthew Rosato <mjrosato@...ux.ibm.com>
> ---
>  arch/s390/pci/pci.c        |  6 ++-
>  drivers/iommu/s390-iommu.c | 95 +++++++++++++++++++++++++++++---------
>  2 files changed, 76 insertions(+), 25 deletions(-)
> 
> diff --git a/arch/s390/pci/pci.c b/arch/s390/pci/pci.c
> index 88f72745fa59..758b23331754 100644
> --- a/arch/s390/pci/pci.c
> +++ b/arch/s390/pci/pci.c
> @@ -124,14 +124,16 @@ int zpci_register_ioat(struct zpci_dev *zdev, u8 dmaas,
>  	struct zpci_fib fib = {0};
>  	u8 cc;
>  
> -	WARN_ON_ONCE(iota & 0x3fff);
>  	fib.pba = base;
>  	/* Work around off by one in ISM virt device */
>  	if (zdev->pft == PCI_FUNC_TYPE_ISM && limit > base)
>  		fib.pal = limit + (1 << 12);
>  	else
>  		fib.pal = limit;
> -	fib.iota = iota | ZPCI_IOTA_RTTO_FLAG;
> +	if (iota == 0)
> +		fib.iota = iota;

Taking another look, I think there is a small problem with the logic of
passing iota == 0 to indicate direct mapping. In
zpci_hot_reset_device() we call zpci_register_ioat() with iota set to
virt_to_phys(zdev->dma_table) and while zdev->dma_table is NULL for the
identity domain we can't rely on virt_to_phys(NULL) == NULL.

> +	else
> +		fib.iota = iota | ZPCI_IOTA_RTTO_FLAG;
>  	fib.gd = zdev->gisa;
>  	cc = zpci_mod_fc(req, &fib, status);
>  	if (cc)