linux-kernel - Re: [PATCH 1/3] Revert "tty/serial: Add kgdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5s38S7sJ2mka3-1@smile.fi.intel.com>
Date: Thu, 30 Jan 2025 10:27:29 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Douglas Anderson <dianders@...omium.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Daniel Thompson <danielt@...nel.org>,
	"Dr . David Alan Gilbert" <linux@...blig.org>,
	kgdb-bugreport@...ts.sourceforge.net,
	Anton Vorontsov <anton.vorontsov@...aro.org>,
	Sumit Garg <sumit.garg@...aro.org>, linux-serial@...r.kernel.org,
	Arnd Bergmann <arnd@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Hugo Villeneuve <hvilleneuve@...onoff.com>,
	Jason Wessel <jason.wessel@...driver.com>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>,
	Niklas Schnelle <schnelle@...ux.ibm.com>,
	Robert Marko <robert.marko@...tura.hr>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Revert "tty/serial: Add kgdb_nmi driver"

On Wed, Jan 29, 2025 at 08:25:50AM -0800, Douglas Anderson wrote:
> This reverts commit 0c57dfcc6c1d037243c2f8fbf62eab3633326ec0.
> 
> The functionality was supoosed to be used by a later patch in the
> series that never landed [1]. Drop it.
> 
> NOTE: part of functionality was already reverted by commit
> 39d0be87438a ("serial: kgdb_nmi: Remove unused knock code"). Also note
> that this revert is not a clean revert given code changes that have
> happened in the meantime.
> 
> It's obvious that nobody is using this code since the two exposed
> functions (kgdb_register_nmi_console() and
> kgdb_unregister_nmi_console()) are both no-ops if
> "arch_kgdb_ops.enable_nmi" is not defined. No architectures define it.

Fine with me.
Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> [1] https://lore.kernel.org/lkml/1348522080-32629-9-git-send-email-anton.vorontsov@linaro.org/

It might be possible to use Link tag here in a form

Link: URL [1]


-- 
With Best Regards,
Andy Shevchenko