linux-kernel - Re: [PATCH RFC net-next v3 6/8] netconsole: add support for sysdata and CPU population

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130103833.GJ113107@kernel.org>
Date: Thu, 30 Jan 2025 10:38:33 +0000
From: Simon Horman <horms@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kselftest@...r.kernel.org,
	rdunlap@...radead.org, kernel-team@...a.com
Subject: Re: [PATCH RFC net-next v3 6/8] netconsole: add support for sysdata
 and CPU population

On Fri, Jan 24, 2025 at 07:16:45AM -0800, Breno Leitao wrote:
> Add infrastructure to automatically append kernel-generated data (sysdata)
> to netconsole messages. As the first use case, implement CPU number
> population, which adds the CPU that sent the message.
> 
> This change introduces three distinct data types:
> - extradata: The complete set of appended data (sysdata + userdata)
> - userdata: User-provided key-value pairs from userspace
> - sysdata: Kernel-populated data (e.g. cpu=XX)
> 
> The implementation adds a new configfs attribute 'cpu_nr' to control CPU
> number population per target. When enabled, each message is tagged with
> its originating CPU. The sysdata is dynamically updated at message time
> and appended after any existing userdata.
> 
> The CPU number is formatted as "cpu=XX" and is added to the extradata
> buffer, respecting the existing size limits.
> 
> Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Simon Horman <horms@...nel.org>