linux-kernel - RE: [PATCH for-next v9 0/5] On-Demand Paging on SoftRoCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OS3PR01MB98659E07C0DAA1838FFBC70DE5E92@OS3PR01MB9865.jpnprd01.prod.outlook.com>
Date: Thu, 30 Jan 2025 10:51:58 +0000
From: "Daisuke Matsuda (Fujitsu)" <matsuda-daisuke@...itsu.com>
To: 'Jason Gunthorpe' <jgg@...pe.ca>, Joe Klein <joe.klein812@...il.com>
CC: "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"leon@...nel.org" <leon@...nel.org>, "zyjzyj2000@...il.com"
	<zyjzyj2000@...il.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "rpearsonhpe@...il.com"
	<rpearsonhpe@...il.com>, "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
Subject: RE: [PATCH for-next v9 0/5] On-Demand Paging on SoftRoCE

On Tue, Jan 14, 2025 5:16 AM Jason Gunthorpe:
> On Mon, Jan 13, 2025 at 02:15:27PM +0100, Joe Klein wrote:
> 
> > > > > Possibly, there was a regression in libibverbs between v39.0-1 and v50.0-2build2.
> > > > > We need to take a closer look to resolve the malfunction of rxe on Ubuntu 24.04.
> > > >
> > > > That's distressing.

I am going to start bisecting the root cause to fix it.
It may take a while, so please stay patient.

> > > >
> > > > > In conclusion, I believe there is nothing in my ODP patches that could cause
> > > > > the rxe driver to fail. I would appreciate any feedback on potential improvements.
> > > >
> > > > What am I supposed to do with this though?
> > > >
> > > > Joe, can you please answer Daisuke's questions on what problems you
> > > > observed and if you observe them without the ODP patches?
> > >
> > > Will make tests and let you know the result very soon.
> >
> > Need time to complete the test scenario configurations.
> >
> > We made tests again. Some memory errors are from RXE ODP.
> > The whole tests can not be complete with this patch set.
> > Without this patch set, all the tests can pass.
> 
> Can you share your logs so that Daisuke can resolve whatever the
> problem is?

Since Joe does not provide any specific information, it would be nice
if someone familiar with rxe like Zhu Yanjun, Li Zhijian or Bob Pearson
could find the time to test and review the patch.
Cf. https://github.com/ddmatsu/linux/tree/odp_v9

However, to be honest, I do not think Joe's report is valid. It is not normal to
complain other's patches without providing any details. It makes difficult to 
assess the validity of the claim, and blocks any further discussions forever.

The testcases in libibverbs pass as I attached the log. Other than that, I verified
my patches work with perftest (with ODP enabled/disabled). I believe I did the
test properly and the patches are ready to be merged.

Daisuke

> 
> Jason