linux-kernel - Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and syscall_set_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250130112207.GA6617@strace.io>
Date: Thu, 30 Jan 2025 13:22:07 +0200
From: "Dmitry V. Levin" <ldv@...ace.io>
To: Sven Schnelle <svens@...ux.ibm.com>
Cc: linux-snps-arc@...ts.infradead.org, Rich Felker <dalias@...c.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andreas Larsson <andreas@...sler.com>,
	John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
	x86@...nel.org, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	Guo Ren <guoren@...nel.org>, linux-csky@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>, sparclinux@...r.kernel.org,
	linux-hexagon@...r.kernel.org, WANG Xuerui <kernel@...0n.name>,
	Will Deacon <will@...nel.org>,
	Eugene Syromyatnikov <evgsyr@...il.com>,
	Anton Ivanov <anton.ivanov@...bridgegreys.com>,
	Jonas Bonn <jonas@...thpole.se>, linux-s390@...r.kernel.org,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Madhavan Srinivasan <maddy@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	linux-sh@...r.kernel.org, Michael Ellerman <mpe@...erman.id.au>,
	Helge Deller <deller@....de>, Huacai Chen <chenhuacai@...nel.org>,
	Russell King <linux@...linux.org.uk>,
	Christophe Leroy <christophe.leroy@...roup.eu>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>, Vineet Gupta <vgupta@...nel.org>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	strace-devel@...ts.strace.io, linux-arch@...r.kernel.org,
	Albert Ou <aou@...s.berkeley.edu>,
	Mike Frysinger <vapier@...too.org>,
	Davide Berardi <berardi.dav@...il.com>,
	Renzo Davoli <renzo@...unibo.it>, linux-um@...ts.infradead.org,
	Heiko Carstens <hca@...ux.ibm.com>,
	Charlie Jenkins <charlie@...osinc.com>,
	Naveen N Rao <naveen@...nel.org>,
	Nicholas Piggin <npiggin@...il.com>,
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
	Borislav Petkov <bp@...en8.de>, loongarch@...ts.linux.dev,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Stafford Horne <shorne@...il.com>,
	linux-arm-kernel@...ts.infradead.org,
	Brian Cain <bcain@...cinc.com>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	linux-parisc@...r.kernel.org, linux-openrisc@...r.kernel.org,
	linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
	Oleg Nesterov <oleg@...hat.com>, Dinh Nguyen <dinguyen@...nel.org>,
	linux-riscv@...ts.infradead.org,
	Palmer Dabbelt <palmer@...belt.com>,
	Richard Weinberger <richard@....at>,
	Johannes Berg <johannes@...solutions.net>,
	Alexey Gladkov <legion@...nel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v3 2/6] syscall.h: add syscall_set_arguments() and
 syscall_set_return_value()

On Thu, Jan 30, 2025 at 09:33:03AM +0100, Sven Schnelle wrote:
> "Dmitry V. Levin" <ldv@...ace.io> writes:
> 
> > These functions are going to be needed on all HAVE_ARCH_TRACEHOOK
> > architectures to implement PTRACE_SET_SYSCALL_INFO API.
> >
> > This partially reverts commit 7962c2eddbfe ("arch: remove unused
> > function syscall_set_arguments()") by reusing some of old
> > syscall_set_arguments() implementations.
> >
> > Signed-off-by: Dmitry V. Levin <ldv@...ace.io>
> > Tested-by: Charlie Jenkins <charlie@...osinc.com>
> > Reviewed-by: Charlie Jenkins <charlie@...osinc.com>
> > ---
> >  arch/arc/include/asm/syscall.h        | 14 +++++++++++
> >  arch/arm/include/asm/syscall.h        | 13 ++++++++++
> >  arch/arm64/include/asm/syscall.h      | 13 ++++++++++
> >  arch/csky/include/asm/syscall.h       | 13 ++++++++++
> >  arch/hexagon/include/asm/syscall.h    | 14 +++++++++++
> >  arch/loongarch/include/asm/syscall.h  |  8 ++++++
> >  arch/mips/include/asm/syscall.h       | 32 ++++++++++++++++++++++++
> >  arch/nios2/include/asm/syscall.h      | 11 ++++++++
> >  arch/openrisc/include/asm/syscall.h   |  7 ++++++
> >  arch/parisc/include/asm/syscall.h     | 12 +++++++++
> >  arch/powerpc/include/asm/syscall.h    | 10 ++++++++
> >  arch/riscv/include/asm/syscall.h      |  9 +++++++
> >  arch/s390/include/asm/syscall.h       | 12 +++++++++
> >  arch/sh/include/asm/syscall_32.h      | 12 +++++++++
> >  arch/sparc/include/asm/syscall.h      | 10 ++++++++
> >  arch/um/include/asm/syscall-generic.h | 14 +++++++++++
> >  arch/x86/include/asm/syscall.h        | 36 +++++++++++++++++++++++++++
> >  arch/xtensa/include/asm/syscall.h     | 11 ++++++++
> >  include/asm-generic/syscall.h         | 16 ++++++++++++
> >  19 files changed, 267 insertions(+)
> >
> > diff --git a/arch/s390/include/asm/syscall.h b/arch/s390/include/asm/syscall.h
> > index 27e3d804b311..b3dd883699e7 100644
> > --- a/arch/s390/include/asm/syscall.h
> > +++ b/arch/s390/include/asm/syscall.h
> > @@ -78,6 +78,18 @@ static inline void syscall_get_arguments(struct task_struct *task,
> >  	args[0] = regs->orig_gpr2 & mask;
> >  }
> >  
> > +static inline void syscall_set_arguments(struct task_struct *task,
> > +					 struct pt_regs *regs,
> > +					 const unsigned long *args)
> > +{
> > +	unsigned int n = 6;
> > +
> > +	while (n-- > 0)
> > +		if (n > 0)
> > +			regs->gprs[2 + n] = args[n];
> > +	regs->orig_gpr2 = args[0];
> > +}
> 
> Could that be changed to something like:
> 
> for (int n = 1; n < 6; n++)
>         regs->gprs[2 + n] = args[n];
> regs->orig_gpr2 = args[0];
> 
> I think this is way easier to parse.

I don't mind changing syscall_set_arguments() this way, but it just
mirrors syscall_get_arguments(), so I think it would be better if these
two functions were written in the same style.  Would you like to change
syscall_get_arguments() as well?


-- 
ldv