linux-kernel - Re: [PATCH] rust: task: make Pid type alias public

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <875xlwfsek.fsf@kloenk.dev>
Date: Thu, 30 Jan 2025 12:33:07 +0100
From: Fiona Behrens <me@...enk.dev>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,  Boqun Feng <boqun.feng@...il.com>,
  Gary Guo <gary@...yguo.net>,  Björn Roy Baron
 <bjorn3_gh@...tonmail.com>,  Benno Lossin <benno.lossin@...ton.me>,
  Andreas Hindborg <a.hindborg@...nel.org>,  Trevor Gross
 <tmgross@...ch.edu>,  rust-for-linux@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: task: make Pid type alias public

Alice Ryhl <aliceryhl@...gle.com> writes:

> The Pid type alias represents the integer type used for pids in the
> kernel. It's the Rust equivalent to pid_t, and there are various methods
> on Task that use Pid as the return type.
>
> Binder needs to use Pid as the type for function arguments and struct
> fields in many places. Thus, make the type public so that Binder can
> access it.
>
> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>

Reviewed-by:  Fiona Behrens <me@...enk.dev>

> ---
>  rust/kernel/task.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/task.rs b/rust/kernel/task.rs
> index 07bc22a7645c..49012e711942 100644
> --- a/rust/kernel/task.rs
> +++ b/rust/kernel/task.rs
> @@ -106,7 +106,7 @@ unsafe impl Send for Task {}
>  unsafe impl Sync for Task {}
>  
>  /// The type of process identifiers (PIDs).
> -type Pid = bindings::pid_t;
> +pub type Pid = bindings::pid_t;
>  
>  /// The type of user identifiers (UIDs).
>  #[derive(Copy, Clone)]
>
> ---
> base-commit: ceff0757f5dafb5be5205988171809c877b1d3e3
> change-id: 20250130-task-pid-pub-484458aec19b
>
> Best regards,