linux-kernel - Re: [PATCH 2/3] drm/panfrost: Add support for Mali on the MT8370 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <194b7237128.10f9923a41656565.5574753983898665940@collabora.com>
Date: Thu, 30 Jan 2025 13:15:40 +0100
From: Louis-Alexis Eyraud <louisalexis.eyraud@...labora.com>
To: "Krzysztof Kozlowski" <krzk@...nel.org>
Cc: "Maarten Lankhorst" <maarten.lankhorst@...ux.intel.com>,
	"Maxime Ripard" <mripard@...nel.org>,
	"Thomas Zimmermann" <tzimmermann@...e.de>,
	"David Airlie" <airlied@...il.com>,
	"Simona Vetter" <simona@...ll.ch>, "Rob Herring" <robh@...nel.org>,
	"Krzysztof Kozlowski" <krzk+dt@...nel.org>,
	"Conor Dooley" <conor+dt@...nel.org>,
	"Matthias Brugger" <matthias.bgg@...il.com>,
	"AngeloGioacchino Del Regno" <angelogioacchino.delregno@...labora.com>,
	"Boris Brezillon" <boris.brezillon@...labora.com>,
	"Steven Price" <steven.price@....com>,
	"kernel" <kernel@...labora.com>,
	"dri-devel" <dri-devel@...ts.freedesktop.org>,
	"devicetree" <devicetree@...r.kernel.org>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>,
	"linux-mediatek" <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH 2/3] drm/panfrost: Add support for Mali on the MT8370
 SoC

Hello,

sorry for the delay,

 ---- On Sat, 18 Jan 2025 17:08:10 +0100  Krzysztof Kozlowski  wrote --- 
 > On Thu, Jan 16, 2025 at 03:25:58PM +0100, Louis-Alexis Eyraud wrote:
 > > This commit adds a compatible for the MediaTek MT8370 SoC, with an
 > > integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core), and adds
 > > platform data using the same supplies and the same power domain lists
 > > as MT8186 (one regulator, two power domains).
 > > 
 > > Signed-off-by: Louis-Alexis Eyraud louisalexis.eyraud@...labora.com>
 > > ---
 > >  drivers/gpu/drm/panfrost/panfrost_drv.c | 10 ++++++++++
 > >  1 file changed, 10 insertions(+)
 > > 
 > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
 > > index 0f3935556ac761adcd80197d87e8e478df436fd5..1d51b64ed0f0660cc95263a289d5dad204540cfd 100644
 > > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
 > > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
 > > @@ -837,6 +837,15 @@ static const struct panfrost_compatible mediatek_mt8192_data = {
 > >      .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF),
 > >  };
 > >  
 > > +/* MT8370 uses the same power domains and power supplies as MT8186 */
 > > +static const struct panfrost_compatible mediatek_mt8370_data = {
 > > +    .num_supplies = ARRAY_SIZE(mediatek_mt8183_b_supplies) - 1,
 > > +    .supply_names = mediatek_mt8183_b_supplies,
 > > +    .num_pm_domains = ARRAY_SIZE(mediatek_mt8186_pm_domains),
 > > +    .pm_domain_names = mediatek_mt8186_pm_domains,
 > > +    .pm_features = BIT(GPU_PM_CLK_DIS) | BIT(GPU_PM_VREG_OFF),
 > > +};
 > 
 > No, people, stop this nonsense. This is exactly the same as previous.
 > Don't duplicate entries just because you want a commit.
 > 
I added this new compatible in bindings and panfrost driver because there were no other matching compatible 
Using another mali-vallhal-jm compatible would make the driver probe fail because of power domains number difference. 
Using mt8186-mali compatible would work without modifications but as it is not the same architecture (mali-bifrost), it would be incorrect.

I've also misguessed on the dt_match array modifications, sorry.
I'll amend this patch in order to reuse the mt8186 platform data instead.

 > > +
 > >  static const struct of_device_id dt_match[] = {
 > >      /* Set first to probe before the generic compatibles */
 > >      { .compatible = "amlogic,meson-gxm-mali",
 > > @@ -859,6 +868,7 @@ static const struct of_device_id dt_match[] = {
 > >      { .compatible = "mediatek,mt8186-mali", .data = &mediatek_mt8186_data },
 > >      { .compatible = "mediatek,mt8188-mali", .data = &mediatek_mt8188_data },
 > >      { .compatible = "mediatek,mt8192-mali", .data = &mediatek_mt8192_data },
 > > +    { .compatible = "mediatek,mt8370-mali", .data = &mediatek_mt8370_data },
 > 
 > No, express properly compatibility or say in bindings commit msg why
 > devices are not compatible.
 > 
I'll reword in V2 the commit messages to make the compatible need more explicit.

 > Best regards,
 > Krzysztof
 > 
 > 

Regards,
Louis-Alexis Eyraud