linux-kernel - Re: [PATCH RFC 2/2] cxl/memdev: Remove temporary variables from cxl_memdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130001549.xtvbvgzma43sn6dj@offworld>
Date: Wed, 29 Jan 2025 16:15:49 -0800
From: Davidlohr Bueso <dave@...olabs.net>
To: Ira Weiny <ira.weiny@...el.com>
Cc: Dave Jiang <dave.jiang@...el.com>,
	Dan Williams <dan.j.williams@...el.com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Vishal Verma <vishal.l.verma@...el.com>, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC 2/2] cxl/memdev: Remove temporary variables from
 cxl_memdev_state

On Tue, 28 Jan 2025, Ira Weiny wrote:

>As was mentioned by Dan[1] cxl_memdev_state stores values which are only
>used during device probe.  This clutters the data structure and is a
>hindrance on code maintenance.  Those values are best handled with
>temporary variables.
>
>Adjust the query of memory devices to read byte sizes in one call which
>takes partition information into account.  Use the values to create
>partitions for device state initialization.  Take care to separate the
>mailbox queries from the initialization of device state to steer the
>mbox code toward taking mailbox objects rather than memdev states.
>Update spec references while changing these calls.
>
>Link: https://lore.kernel.org/all/67871f05cd767_20f32947f@dwillia2-xfh.jf.intel.com.notmuch/ [1]
>Signed-off-by: Ira Weiny <ira.weiny@...el.com>

Reviewed-by: Davidlohr Bueso <dave@...olabs.net>