linux-kernel - Re: [PATCH] wifi: nl80211: override all other flags if MONITOR_FLAG_COOK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14c5edc71a74049c49d51960249b0aefc77208be.camel@sipsolutions.net>
Date: Thu, 30 Jan 2025 13:36:28 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Vitaliy Shevtsov <v.shevtsov@...integration.ru>
Cc: "John W. Linville" <linville@...driver.com>, Michael Wu
	 <flamingice@...rmilk.net>, linux-wireless@...r.kernel.org, 
	linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org, 
	syzbot+2e5c1e55b9e5c28a3da7@...kaller.appspotmail.com
Subject: Re: [PATCH] wifi: nl80211: override all other flags if
 MONITOR_FLAG_COOK_FRAMES is set

On Thu, 2025-01-30 at 17:34 +0500, Vitaliy Shevtsov wrote:
> It is possible to set both MONITOR_FLAG_COOK_FRAMES and MONITOR_FLAG_ACTIVE
> flags simultaneously on the same monitor interface from the userspace. This
> causes a sub-interface to be created with no IEEE80211_SDATA_IN_DRIVER bit
> set because the monitor interface is in the cooked state and it takes
> precedence over all other states. When the interface is then being deleted
> the kernel calls WARN_ONCE() from check_sdata_in_driver() because of missing
> that bit.
> 
> Fix this by overriding all flags if MONITOR_FLAG_COOK_FRAMES is set because
> this flag is incompatible with other monitor flags being set.
> 

That seems wrong, reject it instead. Anyway we should probably remove
cooked mode.

johannes