linux-kernel - Re: [PATCH 12/13] drm/vkms: Allow to configure multiple connectors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5uDKKlLPTWHtFzr@louis-chauvet-laptop>
Date: Thu, 30 Jan 2025 14:48:24 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: José Expósito <jose.exposito89@...il.com>
Cc: hamohammed.sa@...il.com, simona@...ll.ch, melissa.srw@...il.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, airlied@...il.com,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/13] drm/vkms: Allow to configure multiple connectors

On 29/01/25 - 12:00, José Expósito wrote:
> Add a list of connectors to vkms_config and helper functions to add and
> remove as many connectors as wanted.
> 
> Unlike planes, CRTCs and encoders, connectors can be added and removed
> once the device is created. To reflect it, add an "enabled" flag in the
> configuration and filter disabled connectors in the
> vkms_config_get_connectors() function.
> 
> For the moment, changing the enabled status of the connector has no
> effect after the device is created, but a future patch will add this
> capability.
> 
> For backwards compatibility, add one enabled connector to the default
> configuration.
> 
> A future patch will allow to attach connectors and encoders, but for the
> moment there are no changes in the way the output is configured.
> 
> Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
> Signed-off-by: José Expósito <jose.exposito89@...il.com>

Co-developped-by: Louis Chauvet <louis.chauvet@...tlin.com>
Signed-off-by: Louis Chauvet <louis.chauvet@...tlin.com>
Signed-off-by: José Expósito <jose.exposito89@...il.com>

Same comments as previous commits:
- I am not fan of the add/destroy naming
- I think it is better to have an iterator to use connectors