linux-kernel - Re: [PATCH RFC 2/2] cxl/memdev: Remove temporary variables from cxl_memdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <679b97732702b_24e5d72945a@iweiny-mobl.notmuch>
Date: Thu, 30 Jan 2025 09:14:59 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: Jonathan Cameron <Jonathan.Cameron@...wei.com>, Ira Weiny
	<ira.weiny@...el.com>
CC: Dave Jiang <dave.jiang@...el.com>, Dan Williams
	<dan.j.williams@...el.com>, Davidlohr Bueso <dave@...olabs.net>, "Alison
 Schofield" <alison.schofield@...el.com>, Vishal Verma
	<vishal.l.verma@...el.com>, <linux-cxl@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC 2/2] cxl/memdev: Remove temporary variables from
 cxl_memdev_state

Jonathan Cameron wrote:
> On Tue, 28 Jan 2025 12:51:08 -0600
> Ira Weiny <ira.weiny@...el.com> wrote:
> 
> > As was mentioned by Dan[1] cxl_memdev_state stores values which are only
> > used during device probe.  This clutters the data structure and is a
> > hindrance on code maintenance.  Those values are best handled with
> > temporary variables.
> > 
> > Adjust the query of memory devices to read byte sizes in one call which
> > takes partition information into account.  Use the values to create
> > partitions for device state initialization.  Take care to separate the
> > mailbox queries from the initialization of device state to steer the
> > mbox code toward taking mailbox objects rather than memdev states.
> > Update spec references while changing these calls.
> Why not jump to 3.2? 

<shrug> Just been in the 3.1 spec for so long I forgot.

> > 
> > Link: https://lore.kernel.org/all/67871f05cd767_20f32947f@dwillia2-xfh.jf.intel.com.notmuch/ [1]
> > Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 
> Not sure why you had this as an RFC!
> Was it just that we are waiting for v3 from Dan?

Yes.  I wanted to get these out there for Alejandro to see the direction
of the dev state call.

> 
> If so maybe Dan, just stick these on the back of your series if you are
> happen with these and make Dave's job a tiny bit easier (and so
> rebases happen without needing to sync the two sets).

That is fine with me if Dan has time.

Ira