linux-kernel - Re: [PATCH 0/2] A couple of build fixes for x86 when using GCC 15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202501300804.20D8CC2@keescook>
Date: Thu, 30 Jan 2025 08:07:30 -0800
From: Kees Cook <kees@...nel.org>
To: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Cc: Nathan Chancellor <nathan@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
	Sam James <sam@...too.org>, Masahiro Yamada <masahiroy@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org,
	linux-efi@...r.kernel.org, stable@...r.kernel.org,
	Kostadin Shishmanov <kostadinshishmanov@...tonmail.com>,
	Jakub Jelinek <jakub@...hat.com>
Subject: Re: [PATCH 0/2] A couple of build fixes for x86 when using GCC 15

On Tue, Jan 21, 2025 at 06:11:32PM -0700, Nathan Chancellor wrote:
> GCC 15 changed the default C standard version from gnu17 to gnu23, which
> reveals a few places in the kernel where a C standard version was not
> set, resulting in build failures because bool, true, and false are
> reserved keywords in C23 [1][2]. Update these places to use the same C
> standard version as the rest of the kernel, gnu11.

Hello x86 maintainers!

I think this would be valuable to get into -rc1 since we're getting very
close to a GCC 15 release. Can someone get this into -tip urgent,
please? If everyone is busy I can take it via the hardening tree, as we
appear to be the ones tripping over it the most currently. :)

-Kees

> [1]: https://lore.kernel.org/4OAhbllK7x4QJGpZjkYjtBYNLd_2whHx9oFiuZcGwtVR4hIzvduultkgfAIRZI3vQpZylu7Gl929HaYFRGeMEalWCpeMzCIIhLxxRhq4U-Y=@protonmail.com/
> [2]: https://lore.kernel.org/Z4467umXR2PZ0M1H@tucnak/
> 
> ---
> Nathan Chancellor (2):
>       x86/boot: Use '-std=gnu11' to fix build with GCC 15
>       efi: libstub: Use '-std=gnu11' to fix build with GCC 15
> 
>  arch/x86/boot/compressed/Makefile     | 1 +
>  drivers/firmware/efi/libstub/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> ---
> base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
> change-id: 20250121-x86-use-std-consistently-gcc-15-f95146e0050f
> 
> Best regards,
> -- 
> Nathan Chancellor <nathan@...nel.org>
> 

-- 
Kees Cook