linux-kernel - Re: [PATCH net 3/3] net: ethtool: tsconfig: Fix netlink type of hwtstamp flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250130084358.5e895d2c@kernel.org>
Date: Thu, 30 Jan 2025 08:43:58 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Donald Hunter
 <donald.hunter@...il.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net 3/3] net: ethtool: tsconfig: Fix netlink type of
 hwtstamp flags

On Thu, 30 Jan 2025 10:27:16 +0100 Kory Maincent wrote:
> > In general IMHO YNL makes the bitset functionality less important.  
> 
> Do you mean you prefer u32 for bitfield instead of the bitset type? Why?

Not in this case, but in general uint can carry up to 64 bits, 
and the names of the fields are in the spec (both Python and 
C code automatically decode them based on the spec). I see less
of a need for the complex "forward compatibility" handling
in the kernel because of that.