linux-kernel - Re: [PATCH 1/3] gpio: bcm-kona: Fix GPIO lock/unlock for banks above bank 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGt4E5spr9gdroYnvOqCR=YG8spNfOomTrUqPAynnQYP8a-jXQ@mail.gmail.com>
Date: Thu, 30 Jan 2025 14:00:05 -0800
From: Markus Mayer <mmayer@...adcom.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: Artur Weber <aweber.kernel@...il.com>, Ray Jui <rjui@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Scott Branden <sbranden@...adcom.com>, Markus Mayer <markus.mayer@...aro.org>, 
	Tim Kryger <tim.kryger@...aro.org>, Matt Porter <matt.porter@...aro.org>, 
	Christian Daudt <csd@...adcom.com>, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 1/3] gpio: bcm-kona: Fix GPIO lock/unlock for banks above
 bank 0

On Thu, 30 Jan 2025 at 13:33, Florian Fainelli
<florian.fainelli@...adcom.com> wrote:
>
> On 1/30/25 09:10, Artur Weber wrote:
> > The GPIO lock/unlock functions clear/write a bit to the relevant
> > register for each bank. However, due to an oversight the bit that
> > was being written was based on the total GPIO number, not the index
> > of the GPIO within the relevant bank, causing it to fail for any
> > GPIO above 32 (thus any GPIO for banks above bank 0).
> >
> > Fix lock/unlock for these banks by using the correct bit.
> >
> > Fixes: bdb93c03c550 ("gpio: bcm281xx: Centralize register locking")
> > Signed-off-by: Artur Weber <aweber.kernel@...il.com>
>
> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>

Wow. That recipient list brings back memories.

Also:

Reviewed-by: Markus Mayer <mmayer@...adcom.com>