linux-kernel - Re: [PATCH] mei: Remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8c9f6d8f-cf4f-476c-aeda-25a68ea36b0b@app.fastmail.com>
Date: Fri, 31 Jan 2025 08:09:34 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: linux@...blig.org, "Alexander Usyskin" <alexander.usyskin@...el.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mei: Remove unused functions

On Thu, Jan 30, 2025, at 02:26, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>

It looks like git-send-email failed to find your cleartext
name in gitconfig.

> The following functions have been in the mei code for
> a long time but have never been used.
>
> mei_txe_setup_satt2() was added in 2014 by
> commit 32e2b59fca2c ("mei: txe: add hw-txe.c")
>
> mei_me_cl_rm_by_uuid_id() was added in 2015 by
> commit 79563db9ddd3 ("mei: add reference counting for me clients")
>
> mei_cldev_uuid() was added in 2015 by
> commit baeacd037697 ("mei: bus: export uuid and protocol version to mei_cl
> bus drivers")
>
> mei_cldev_recv_nonblock() was added in 2016 by
> commit 076802d00615 ("mei: bus: enable non-blocking RX")
> it is the only user of mei_cldev_recv_nonblock_vtag().
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>

Makes sense to me. IIRC there are part of mei that are only
used by out of tree code, but this is normally discouraged,
so no objections from me on that.

Acked-by: Arnd Bergmann <arnd@...db.de>

      Arnd