linux-kernel - Re: [PATCH v2] usb: gadget: f_midi: fix MIDI Streaming descriptor lengths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tt9f4dkp.wl-tiwai@suse.de>
Date: Fri, 31 Jan 2025 09:01:10 +0100
From: Takashi Iwai <tiwai@...e.de>
To: John Keeping <jkeeping@...usicbrands.com>
Cc: linux-usb@...r.kernel.org,
	Takashi Iwai <tiwai@...e.de>,
	stable@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Kees Cook <kees@...nel.org>,
	Abdul Rahim <abdul.rahim@...ahoo.com>,
	Jeff Johnson <quic_jjohnson@...cinc.com>,
	Michael Grzeschik <m.grzeschik@...gutronix.de>,
	Daniel Mack <zonque@...il.com>,
	Felipe Balbi <balbi@...com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] usb: gadget: f_midi: fix MIDI Streaming descriptor lengths

On Thu, 30 Jan 2025 20:50:34 +0100,
John Keeping wrote:
> 
> While the MIDI jacks are configured correctly, and the MIDIStreaming
> endpoint descriptors are filled with the correct information,
> bNumEmbMIDIJack and bLength are set incorrectly in these descriptors.
> 
> This does not matter when the numbers of in and out ports are equal, but
> when they differ the host will receive broken descriptors with
> uninitialized stack memory leaking into the descriptor for whichever
> value is smaller.
> 
> The precise meaning of "in" and "out" in the port counts is not clearly
> defined and can be confusing.  But elsewhere the driver consistently
> uses this to match the USB meaning of IN and OUT viewed from the host,
> so that "in" ports send data to the host and "out" ports receive data
> from it.
> 
> Cc: stable@...r.kernel.org
> Fixes: c8933c3f79568 ("USB: gadget: f_midi: allow a dynamic number of input and output ports")
> Signed-off-by: John Keeping <jkeeping@...usicbrands.com>

Reviewed-by: Takashi Iwai <tiwai@...e.de>


Thanks!

Takashi