linux-kernel - Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible array member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250131090600.04b8f4f7.pasic@linux.ibm.com>
Date: Fri, 31 Jan 2025 09:06:00 +0100
From: Halil Pasic <pasic@...ux.ibm.com>
To: Heiko Carstens <hca@...ux.ibm.com>
Cc: Alexander Gordeev <agordeev@...ux.ibm.com>,
        "Gustavo A. R. Silva"
 <gustavo@...eddedor.com>,
        Thorsten Blum <thorsten.blum@...ux.dev>,
        Tony
 Krowiak <akrowiak@...ux.ibm.com>,
        Jason Herne <jjherne@...ux.ibm.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Holger Dengler
 <dengler@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Christian
 Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle
 <svens@...ux.ibm.com>, linux-hardening@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org,
        Halil Pasic
 <pasic@...ux.ibm.com>
Subject: Re: [PATCH] s390/vfio-ap: Replace one-element array with flexible
 array member

On Thu, 30 Jan 2025 13:46:47 +0100
Heiko Carstens <hca@...ux.ibm.com> wrote:

> > > Thanks! Alex, what do we do with this then? I think you picked it up
> > > yesterday late. And I think, it might make sense to make this look
> > > less like a fake flex-array...  
> > 
> > Dropped.
> > Thanks for looking into it!  
> 
> Given that we already have 5dd4241964c8 ("vfio/ccw: replace one-element
> array with flexible-array member") applied, we now end up with inconsistent
> code. I'd prefer if we address _both_ code locations in a way that the code
> looks similar, and people won't send similar patches again and again.
> 

Yes, I agree. We should make this not look like a fake flex array.

> Halil, since you started this discussion, can you address this please?

Sure! But I won't get around before late in the evening.

Regards,
Halil