linux-kernel - Re: [PATCH 6/7] arm64: dts: rockchip: Add rng node to RK3588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a0f3d55-3828-43c9-b2d2-291f767c50e0@kernel.org>
Date: Fri, 31 Jan 2025 11:16:59 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>,
 Philipp Zabel <p.zabel@...gutronix.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>,
 Olivia Mackall <olivia@...enic.com>, Herbert Xu
 <herbert@...dor.apana.org.au>, Daniel Golle <daniel@...rotopia.org>,
 Aurelien Jarno <aurelien@...el32.net>
Cc: Sebastian Reichel <sebastian.reichel@...labora.com>,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
 linux-crypto@...r.kernel.org
Subject: Re: [PATCH 6/7] arm64: dts: rockchip: Add rng node to RK3588

On 30/01/2025 17:31, Nicolas Frattaroli wrote:
> Add the RK3588's standalone hardware random number generator node to its
> device tree, and enable it on the one board I've tested it on and can
> verify it produces good output, the Rock 5B.
> 
> Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@...labora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588-base.dtsi   | 9 +++++++++
>  arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 4 ++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> index 8cfa30837ce72581d0b513a8274ab0177eb5ae15..1c72922bcbe1afd7c49beac771f8b7c6e5cc6e05 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
> @@ -1921,6 +1921,15 @@ sdhci: mmc@...e0000 {
>  		status = "disabled";
>  	};
>  
> +	rng: rng@...78000 {
> +		compatible = "rockchip,rk3588-rng";
> +		reg = <0x0 0xfe378000 0x0 0x200>;
> +		interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH 0>;
> +		clocks = <&scmi_clk SCMI_HCLK_SECURE_NS>;
> +		resets = <&scmi_reset SCMI_SRST_H_TRNG_NS>;
> +		status = "disabled";

Why? What resources are missing?

> +	};
> +
>  	i2s0_8ch: i2s@...70000 {
>  		compatible = "rockchip,rk3588-i2s-tdm";
>  		reg = <0x0 0xfe470000 0x0 0x1000>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index d597112f1d5b8ee0b6a4fa17086c8671a5102583..00a915cf266202e26b274cab962f7bf6bcf76fc1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -430,6 +430,10 @@ &pwm1 {
>  	status = "okay";
>  };
>  
> +&rng {
> +	status = "okay";

I don't see how RNG is board related.


Best regards,
Krzysztof