linux-kernel - Re: [PATCH] WIP: drivers/base: Add virtual_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z5ypQ3VdJw_pLKBr@smile.fi.intel.com>
Date: Fri, 31 Jan 2025 12:43:15 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Lyude Paul <lyude@...hat.com>
Cc: rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	Danilo Krummrich <dakr@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maíra Canal <mairacanal@...eup.net>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Zijun Hu <quic_zijuhu@...cinc.com>,
	Robin Murphy <robin.murphy@....com>,
	Alexander Lobakin <aleksander.lobakin@...el.com>,
	Lukas Wunner <lukas@...ner.de>, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] WIP: drivers/base: Add virtual_device_create()

On Thu, Jan 30, 2025 at 04:28:26PM -0500, Lyude Paul wrote:
> As Greg KH pointed out, we have a nice /sys/devices/virtual directory free
> for the taking - but the vast majority of device drivers concerned with
> virtual devices do not use this and instead misuse the platform device API.
> 
> To fix this, let's start by adding a simple function that can be used for
> creating virtual devices - virtual_device_create().
> 
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> 
> ---
> 
> So, WIP obviously because I wrote this up in a few minutes - but this goes
> off the idea that Danilo suggested to me off-list of coming up with a
> simple API for handling virtual devices that's a little more obvious to
> use. I wanted to get people's feedback and if we're happy with this idea,
> I'm willing to go through and add some pointers to this function in various
> platform API docs - along with porting over the C version of VKMS over to
> this API.

So, if it goes anywhere, please be sure that:
1) it's implemented in a separate *.c and *.h;
2) it won't abuse header inclusions and add into dependency hell;
3) it's documented.

Additionally would be nice to have one user to be converted to see how it may
be done in practice.

-- 
With Best Regards,
Andy Shevchenko