linux-kernel - Re: [PATCH V1] firmware: arm_scmi: Optimize the iteration of scmi_requested

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z5zZ0BnEVKL-vZGa@bogus>
Date: Fri, 31 Jan 2025 14:10:24 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Cristian Marussi <cristian.marussi@....com>
Cc: "Peng Fan (OSS)" <peng.fan@....nxp.com>, <arm-scmi@...r.kernel.org>,
	Sudeep Holla <sudeep.holla@....com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, Peng Fan <peng.fan@....com>,
	Dan Carpenter <dan.carpenter@...aro.org>
Subject: Re: [PATCH V1] firmware: arm_scmi: Optimize the iteration of
 scmi_requested_devices

On Thu, Jan 30, 2025 at 01:07:35PM +0000, Cristian Marussi wrote:
>
> ... having said that, I cannot really recall WHY I decided to avoid ANY
> kind of duplicate naming given that teh match happen by proto_id/name...
>
> ....maybe just for clarity ? not sure...even what the effects could be
> of having such duplicated names across protocols...
>

Looking at scmi_dev_match_id(), it should be fine even if the names are
duplicated across protocols. We must just not allow duplicates within a
protocol IMO. I will push a patch to handle it soon.

--
Regards,
Sudeep