linux-kernel - Re: [PATCH v4 11/18] dt-bindings: gpu: Add 'resets' property for GPU initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed1920cc-7cd5-4af7-a945-bb71296010e3@imgtec.com>
Date: Fri, 31 Jan 2025 15:39:36 +0000
From: Matt Coster <Matt.Coster@...tec.com>
To: Michal Wilczynski <m.wilczynski@...sung.com>,
        "mturquette@...libre.com"
	<mturquette@...libre.com>,
        "sboyd@...nel.org" <sboyd@...nel.org>,
        "robh@...nel.org" <robh@...nel.org>,
        "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>,
        "conor+dt@...nel.org" <conor+dt@...nel.org>,
        "drew@...7.com" <drew@...7.com>,
        "guoren@...nel.org" <guoren@...nel.org>,
        "wefu@...hat.com" <wefu@...hat.com>,
        "jassisinghbrar@...il.com"
	<jassisinghbrar@...il.com>,
        "paul.walmsley@...ive.com"
	<paul.walmsley@...ive.com>,
        "palmer@...belt.com" <palmer@...belt.com>,
        "aou@...s.berkeley.edu" <aou@...s.berkeley.edu>,
        Frank Binns
	<Frank.Binns@...tec.com>,
        "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>,
        "mripard@...nel.org"
	<mripard@...nel.org>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "airlied@...il.com" <airlied@...il.com>,
        "simona@...ll.ch" <simona@...ll.ch>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "jszhang@...nel.org"
	<jszhang@...nel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>
CC: "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v4 11/18] dt-bindings: gpu: Add 'resets' property for GPU
 initialization

On 28/01/2025 19:48, Michal Wilczynski wrote:
> Many RISC-V boards featuring Imagination Technologies GPUs require a
> reset line to be de-asserted as part of the GPU power-up sequence. To
> support this, add a 'resets' property to the GPU device tree bindings.
> This ensures the GPU can be properly initialized on these platforms.

My comment on P10 ("drm/imagination: Add reset controller support for
GPU initialization") applies here too - would you mind rewording this?

Cheers,
Matt

> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Michal Wilczynski <m.wilczynski@...sung.com>
> ---
>  Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index 256e252f8087..bb607d4b1e07 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -37,6 +37,9 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg

-- 
Matt Coster
E: matt.coster@...tec.com


Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (237 bytes)