linux-kernel - Re: [PATCH 1/1] lib/iov_iter: fix import_iovec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e32c027d-7487-49d5-9f44-71e3dba0ecc2@kernel.dk>
Date: Fri, 31 Jan 2025 09:12:42 -0700
From: Jens Axboe <axboe@...nel.dk>
To: Pavel Begunkov <asml.silence@...il.com>,
 Alexander Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Cc: Christian Brauner <brauner@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] lib/iov_iter: fix import_iovec_ubuf iovec management

On 1/31/25 9:06 AM, Pavel Begunkov wrote:
> On 1/31/25 14:13, Pavel Begunkov wrote:
>> import_iovec() says that it should always be fine to kfree the iovec
>> returned in @iovp regardless of the error code. __import_iovec_ubuf()
>> never reallocates it and thus should clear the pointer even in cases
>> when copy_iovec_*() fail.
> 
> To be fair, all callers I checked don't look at the returned iovec
> if import_iovec*() fails, but I didn't track down all of them.

Yep I also checked too and didn't spot any issues from this, but it's
still prudent to clean it up.

-- 
Jens Axboe