| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250131173257.3b0f7df0@imammedo.users.ipa.redhat.com>
Date: Fri, 31 Jan 2025 17:32:57 +0100
From: Igor Mammedov <imammedo@...hat.com>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: "Michael S . Tsirkin" <mst@...hat.com>, Jonathan Cameron
<Jonathan.Cameron@...wei.com>, Shiju Jose <shiju.jose@...wei.com>,
qemu-arm@...gnu.org, qemu-devel@...gnu.org, Ani Sinha
<anisinha@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/13] tests/acpi: virt: add a HEST table to aarch64
virt and update DSDT
On Fri, 31 Jan 2025 16:49:19 +0100
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:
> Em Wed, 29 Jan 2025 16:29:53 +0100
> Igor Mammedov <imammedo@...hat.com> escreveu:
>
> > On Wed, 29 Jan 2025 09:04:18 +0100
> > Mauro Carvalho Chehab <mchehab+huawei@...nel.org> wrote:
> >
> > > DSDT has gained a GED device to notify errors:
> > >
> > > --- a/DSDT.dsl 2025-01-28 09:38:15.155347858 +0100
> > > +++ b/DSDT.dsl 2025-01-28 09:39:01.684836954 +0100
> > > @@ -9,9 +9,9 @@
> > > *
> > > * Original Table Header:
> > > * Signature "DSDT"
> > > - * Length 0x00001516 (5398)
> > > + * Length 0x00001542 (5442)
> > > * Revision 0x02
> > > - * Checksum 0x0F
> > > + * Checksum 0xE9
> > > * OEM ID "BOCHS "
> > > * OEM Table ID "BXPC "
> > > * OEM Revision 0x00000001 (1)
> > > @@ -1931,6 +1931,11 @@
> > > {
> > > Notify (PWRB, 0x80) // Status Change
> > > }
> > > +
> > > + If (((Local0 & 0x10) == 0x10))
> > > + {
> > > + Notify (GEDD, 0x80) // Status Change
> > > + }
> > > }
> > > }
> > >
> > > @@ -1939,6 +1944,12 @@
> > > Name (_HID, "PNP0C0C" /* Power Button Device */) // _HID: Hardware ID
> > > Name (_UID, Zero) // _UID: Unique ID
> > > }
> > > +
> > > + Device (GEDD)
> > > + {
> > > + Name (_HID, "PNP0C33" /* Error Device */) // _HID: Hardware ID
> > > + Name (_UID, Zero) // _UID: Unique ID
> > > + }
> > > }
> > > }
> > >
> > > New HEST table:
> >
> > diff might be a better here,
> > you can have it during make check when expected tables haven't been update yet.
> > prereq for that is to have 'iasl' installed (usually part of acpica-tools package)
> > and adding V=1 to env vars, something like this:
> >
> > V=1 QTEST_QEMU_BINARY=./qemu-system-aarch64 ./tests/qtest/bios-tables-test
>
> Hmm... didn't produce any diff here. I added a diff generated by
> hand (calling iasl before/after the GED wire up patch and manually
> running diff).
that can happen due to stale files which rebuild-expected-aml.sh creates
(I'd check 'git status' output).
And well, rerun configure after iasl has been installed.
> Anyway, as HEST table is not checked, I dropped it file from the tests[1],
> and placed on patch 12/13 just the DSDT diff.
if it's not checked, then it would be better to add it before changes,
and then update here (with new layout)
>
> [1] tests/data/acpi/aarch64/virt/HEST
>
> >
> > >
> > > /*
> > > * Intel ACPI Component Architecture
> > > * AML/ASL+ Disassembler version 20240927 (64-bit version)
> > > * Copyright (c) 2000 - 2023 Intel Corporation
> > > *
> > > * Disassembly of hest.dat
> > > *
> > > * ACPI Data Table [HEST]
> > > *
> > > * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue (in hex)
> > > */
> > >
> > > [000h 0000 004h] Signature : "HEST" [Hardware Error Source Table]
> > > [004h 0004 004h] Table Length : 000000E0
> > > [008h 0008 001h] Revision : 01
> > > [009h 0009 001h] Checksum : 68
> > > [00Ah 0010 006h] Oem ID : "BOCHS "
> > > [010h 0016 008h] Oem Table ID : "BXPC "
> > > [018h 0024 004h] Oem Revision : 00000001
> > > [01Ch 0028 004h] Asl Compiler ID : "BXPC"
> > > [020h 0032 004h] Asl Compiler Revision : 00000001
> > >
> > > [024h 0036 004h] Error Source Count : 00000002
> > >
> > > [028h 0040 002h] Subtable Type : 000A [Generic Hardware Error Source V2]
> > > [02Ah 0042 002h] Source Id : 0000
> > > [02Ch 0044 002h] Related Source Id : FFFF
> > > [02Eh 0046 001h] Reserved : 00
> > > [02Fh 0047 001h] Enabled : 01
> > > [030h 0048 004h] Records To Preallocate : 00000001
> > > [034h 0052 004h] Max Sections Per Record : 00000001
> > > [038h 0056 004h] Max Raw Data Length : 00000400
> > >
> > > [03Ch 0060 00Ch] Error Status Address : [Generic Address Structure]
> > > [03Ch 0060 001h] Space ID : 00 [SystemMemory]
> > > [03Dh 0061 001h] Bit Width : 40
> > > [03Eh 0062 001h] Bit Offset : 00
> > > [03Fh 0063 001h] Encoded Access Width : 04 [QWord Access:64]
> > > [040h 0064 008h] Address : 0000000139E40000
> > >
> > > [048h 0072 01Ch] Notify : [Hardware Error Notification Structure]
> > > [048h 0072 001h] Notify Type : 08 [SEA]
> > > [049h 0073 001h] Notify Length : 1C
> > > [04Ah 0074 002h] Configuration Write Enable : 0000
> > > [04Ch 0076 004h] PollInterval : 00000000
> > > [050h 0080 004h] Vector : 00000000
> > > [054h 0084 004h] Polling Threshold Value : 00000000
> > > [058h 0088 004h] Polling Threshold Window : 00000000
> > > [05Ch 0092 004h] Error Threshold Value : 00000000
> > > [060h 0096 004h] Error Threshold Window : 00000000
> > >
> > > [064h 0100 004h] Error Status Block Length : 00000400
> > > [068h 0104 00Ch] Read Ack Register : [Generic Address Structure]
> > > [068h 0104 001h] Space ID : 00 [SystemMemory]
> > > [069h 0105 001h] Bit Width : 40
> > > [06Ah 0106 001h] Bit Offset : 00
> > > [06Bh 0107 001h] Encoded Access Width : 04 [QWord Access:64]
> > > [06Ch 0108 008h] Address : 0000000139E40010
> > >
> > > [074h 0116 008h] Read Ack Preserve : FFFFFFFFFFFFFFFE
> > > [07Ch 0124 008h] Read Ack Write : 0000000000000001
> > >
> > > [084h 0132 002h] Subtable Type : 000A [Generic Hardware Error Source V2]
> > > [086h 0134 002h] Source Id : 0001
> > > [088h 0136 002h] Related Source Id : FFFF
> > > [08Ah 0138 001h] Reserved : 00
> > > [08Bh 0139 001h] Enabled : 01
> > > [08Ch 0140 004h] Records To Preallocate : 00000001
> > > [090h 0144 004h] Max Sections Per Record : 00000001
> > > [094h 0148 004h] Max Raw Data Length : 00000400
> > >
> > > [098h 0152 00Ch] Error Status Address : [Generic Address Structure]
> > > [098h 0152 001h] Space ID : 00 [SystemMemory]
> > > [099h 0153 001h] Bit Width : 40
> > > [09Ah 0154 001h] Bit Offset : 00
> > > [09Bh 0155 001h] Encoded Access Width : 04 [QWord Access:64]
> > > [09Ch 0156 008h] Address : 0000000139E40008
> > >
> > > [0A4h 0164 01Ch] Notify : [Hardware Error Notification Structure]
> > > [0A4h 0164 001h] Notify Type : 07 [GPIO]
> > > [0A5h 0165 001h] Notify Length : 1C
> > > [0A6h 0166 002h] Configuration Write Enable : 0000
> > > [0A8h 0168 004h] PollInterval : 00000000
> > > [0ACh 0172 004h] Vector : 00000000
> > > [0B0h 0176 004h] Polling Threshold Value : 00000000
> > > [0B4h 0180 004h] Polling Threshold Window : 00000000
> > > [0B8h 0184 004h] Error Threshold Value : 00000000
> > > [0BCh 0188 004h] Error Threshold Window : 00000000
> > >
> > > [0C0h 0192 004h] Error Status Block Length : 00000400
> > > [0C4h 0196 00Ch] Read Ack Register : [Generic Address Structure]
> > > [0C4h 0196 001h] Space ID : 00 [SystemMemory]
> > > [0C5h 0197 001h] Bit Width : 40
> > > [0C6h 0198 001h] Bit Offset : 00
> > > [0C7h 0199 001h] Encoded Access Width : 04 [QWord Access:64]
> > > [0C8h 0200 008h] Address : 0000000139E40018
> > >
> > > [0D0h 0208 008h] Read Ack Preserve : FFFFFFFFFFFFFFFE
> > > [0D8h 0216 008h] Read Ack Write : 0000000000000001
> > >
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> > > ---
> > > tests/data/acpi/aarch64/virt/DSDT | Bin 5196 -> 5240 bytes
> > > .../data/acpi/aarch64/virt/DSDT.acpihmatvirt | Bin 5282 -> 5326 bytes
> > > tests/data/acpi/aarch64/virt/DSDT.memhp | Bin 6557 -> 6601 bytes
> > > tests/data/acpi/aarch64/virt/DSDT.pxb | Bin 7679 -> 7723 bytes
> > > tests/data/acpi/aarch64/virt/DSDT.topology | Bin 5398 -> 5442 bytes
> > > tests/data/acpi/aarch64/virt/HEST | Bin 0 -> 224 bytes
> > > tests/qtest/bios-tables-test-allowed-diff.h | 2 --
> > > 7 files changed, 2 deletions(-)
> > >
> > > diff --git a/tests/data/acpi/aarch64/virt/DSDT b/tests/data/acpi/aarch64/virt/DSDT
> > > index 36d3e5d5a5e47359b6dcb3706f98b4f225677591..a182bd9d7182dccdf63c650d048c58f18505d001 100644
> > > GIT binary patch
> > > delta 109
> > > zcmX@3@...lCD<jTLWF^ViDe>}G*h$dM)euOOwJsW4+;nC=*7E+g>V+Q2D|zsED)Gn
> > > zoxsJ!z{S)S5FX^j)c_F?VBivHb9Z%dnXE4&D;?b=31V}^dw9C=2KWUSI2#)?aKwjt
> > > Hx-b9$X;vI^
> > >
> > > delta 64
> > > zcmeyNaYlp7CD<jzM}&caNqQoeG*i3NM)euOOit{R4+;lM%f`Egg>V+Q2D|zsED)Gn
> > > UoxsJ!z{S)S5FX?-*+E1W06%jPR{#J2
> > >
> > > diff --git a/tests/data/acpi/aarch64/virt/DSDT.acpihmatvirt b/tests/data/acpi/aarch64/virt/DSDT.acpihmatvirt
> > > index e6154d0355f84fdcc51387b4db8f9ee63acae4e9..af1f2b0eb0b77a80c5bd74f201d24f71e486627f 100644
> > > GIT binary patch
> > > delta 110
> > > zcmZ3ac}|ndCD<k8oCpI0)4_>c(oCIR8`a+lGdXii78eO-)SH|wBICY5U~+W=mjDBo
> > > yK%2X(iwjpnbdzL2c#soEyoaX?Z-8HbfwO@...n$Qrwc=LlO#wDl9aJAR0;r(tsHj%
> > >
> > > delta 66
> > > zcmX@...!`CCD<iokq83=(~XH-(oDVX8`a+lGdZzO78eO-l%1R{A|oB$BpDDM<irv0
> > > W;pxH~;1^)vY~akm5g+R5!T<noi4jWx
> > >
> > > diff --git a/tests/data/acpi/aarch64/virt/DSDT.memhp b/tests/data/acpi/aarch64/virt/DSDT.memhp
> > > index 33f011d6b635035a04c0b39ce9b4e219f7ae74b7..10436ec87c4859fb84b3ecb7bba5788f38112e59 100644
> > > GIT binary patch
> > > delta 88
> > > zcmbPheA1Z9CD<k8q$C3algUIbX{MH08`WnBGdXcjJ}4Z_<jXo)OvH<SfxzVI1TFyv
> > > qE`c_8R~MJfaU%At($P(lAPz^oho=i~fM0-tv#~J)M|`NK3j+W#;TF9B
> > >
> > > delta 44
> > > zcmX?UJlB}ZCD<iot|S8klg&gfX{L_p8`WnBGdXfiJ}4Z_<ij#qOvGz*p@...039?8
> > > AE&u=k
> > >
> > > diff --git a/tests/data/acpi/aarch64/virt/DSDT.pxb b/tests/data/acpi/aarch64/virt/DSDT.pxb
> > > index c0fdc6e9c1396cc2259dc4bc665ba023adcf4c9b..0524b3cbe00bfe552de824dd1090bd00a208c527 100644
> > > GIT binary patch
> > > delta 110
> > > zcmexwz1oJ$CD<iITaJN&sbC_PG*jDyjq2XAOwJsWOJsu?^(LQ?m2qDnFu6K`OMrn(
> > > ypv~RY#f7UOx=Au1JjjV7-ow*{H^48zz}di=fg?WD(}f|rNfM+6Ny^w5Dg^+WYaFrw
> > >
> > > delta 66
> > > zcmZ2&^WU1wCD<k8zbpd-Q^!OuX{N5b8`ZsKnVi@...gV)%1%BZD<d7<BpDDM<irv0
> > > W;pxH~;1^)vY~akm5g+R5!T<oNArgiF
> > >
> > > diff --git a/tests/data/acpi/aarch64/virt/DSDT.topology b/tests/data/acpi/aarch64/virt/DSDT.topology
> > > index 029d03eecc4efddc001e5377e85ac8e831294362..8c0423fe62d6950f9098983d86bfee256d7d003a 100644
> > > GIT binary patch
> > > delta 86
> > > zcmbQHbx4cLCD<jzNtA(s>E%Q&X{O%5jp|7vOwJsWyG4Q-^(NmJk>Ot;Fu6K`OMrn(
> > > opv~RY#bxqO5n1WzCP@...i_T)g*U)2z`)tqn1Lfc)YF9l01l28<p2Nx
> > >
> > > delta 42
> > > ycmX@...F1lCD<iIOq79viGL!OG*hGhM)f2SCMWjE-6Fw^vXk$N$V}!Dl?DLb(h64q
> > >
> > > diff --git a/tests/data/acpi/aarch64/virt/HEST b/tests/data/acpi/aarch64/virt/HEST
> > > index e69de29bb2d1d6434b8b29ae775ad8c2e48c5391..8b0cf87700fa1799c0f8e48610ce4b7ff751dd1f 100644
> > > GIT binary patch
> > > literal 224
> > > zcmeZp4Gww0z`($m;pFe^5v<@85#X$#prF9Wz`y`vgJ>oO1_mw$28RFt85lu)5N2Ru
> > > tU|?_nkxwi^d=43qAPxXkD*#pd?>_{9%>kRuh}CQksCsrH%$C4mHUOJBAprmY
> > >
> > > literal 0
> > > HcmV?d00001
> > >
> > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > > index 46298e38e7b8..dfb8523c8bf4 100644
> > > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > > @@ -1,3 +1 @@
> > > /* List of comma-separated changed AML files to ignore */
> > > -"tests/data/acpi/aarch64/virt/HEST",
> > > -"tests/data/acpi/aarch64/virt/DSDT",
> >
>
>
>
> Thanks,
> Mauro
>
Powered by blists - more mailing lists