linux-kernel - wait_event_timeout() usage in decon_wait_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250131165549.GA684322@bhelgaas>
Date: Fri, 31 Jan 2025 10:55:49 -0600
From: Bjorn Helgaas <helgaas@...nel.org>
To: Inki Dae <inki.dae@...sung.com>, Seung-Woo Kim <sw0312.kim@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	dri-devel@...ts.freedesktop.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: wait_event_timeout() usage in decon_wait_for_vblank()

I don't know this code at all, so this is likely just noise, but the
wait_event_timeout() usage in decon_wait_for_vblank() looks funny to
me.

decon_wait_for_vblank() waits on wait_vsync_queue for wait_vsync_event
to be cleared.

But decon_irq_handler() only clears wait_vsync_event and wakes up
wait_vsync_queue when !ctx->i80_if.

I don't see any i80_if connection in decon_wait_for_vblank().  Does
the wait always time out if i80_if is set?  Is there some reason we
don't use decon_wait_for_vblank() at all if i80_if is set?

Bjorn