linux-kernel - Re: [PATCH v2] bcachefs: fix deadlock in journal_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qbago6vr47oqfielablmjiwnegpdoa42ad3rxz4pyv24julqp7@qoerk4wyvfnk>
Date: Fri, 31 Jan 2025 13:32:39 -0500
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Alan Huang <mmpgouride@...il.com>
Cc: Jeongjun Park <aha310510@...il.com>, linux-bcachefs@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] bcachefs: fix deadlock in journal_entry_open()

On Sat, Feb 01, 2025 at 02:12:37AM +0800, Alan Huang wrote:
> On Jan 31, 2025, at 20:47, Jeongjun Park <aha310510@...il.com> wrote:
> > 
> > In the previous commit b3d82c2f2761, code was added to prevent journal sequence
> > overflow. Among them, the code added to journal_entry_open() uses the
> > bch2_fs_fatal_err_on() function to handle errors.
> 
> At least, bch2_journal_halt could invoke bch2_journal_halt_locked.

yep

> Is it possible to release the lock before bch2_fs_fatal_err_on() ? Not familiar with journal code yet.

The control flow makes it awkward, halt_locked() looks like the cleanest
solution.