linux-kernel - Re: [PATCH V5 2/5] dt-bindings: iio: adc: Split out QCOM VADC channel properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <173835251554.3936459.14441041624354472103.robh@kernel.org>
Date: Fri, 31 Jan 2025 13:41:59 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
Cc: rui.zhang@...el.com, lee@...nel.org, agross@...nel.org, 
 konradybcio@...nel.org, cros-qcom-dts-watchers@...omium.org, 
 conor+dt@...nel.org, anjelique.melendez@....qualcomm.com, 
 david.collins@....qualcomm.com, quic_kamalw@...cinc.com, 
 lukasz.luba@....com, devicetree@...r.kernel.org, neil.armstrong@...aro.org, 
 lars@...afoo.de, linux-iio@...r.kernel.org, amitk@...nel.org, 
 linux-arm-msm@...r.kernel.org, daniel.lezcano@...aro.org, jic23@...nel.org, 
 sboyd@...nel.org, krzk+dt@...nel.org, linux-kernel@...r.kernel.org, 
 rafael@...nel.org, linux-pm@...r.kernel.org, thara.gopinath@...il.com, 
 andersson@...nel.org, quic_skakitap@...cinc.com, 
 dmitry.baryshkov@...aro.org, subbaraman.narayanamurthy@....qualcomm.com
Subject: Re: [PATCH V5 2/5] dt-bindings: iio: adc: Split out QCOM VADC
 channel properties


On Sat, 01 Feb 2025 00:02:39 +0530, Jishnu Prakash wrote:
> Split out the common channel properties for QCOM VADC devices into a
> separate file so that it can be included as a reference for devices
> using them. This will be needed for the upcoming ADC5 Gen3 binding
> support patch, as ADC5 Gen3 also uses all of these common properties.
> 
> Signed-off-by: Jishnu Prakash <jishnu.prakash@....qualcomm.com>
> ---
>  .../iio/adc/qcom,spmi-vadc-common.yaml        | 87 +++++++++++++++++++
>  .../bindings/iio/adc/qcom,spmi-vadc.yaml      | 75 +---------------
>  2 files changed, 89 insertions(+), 73 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc-common.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.example.dts:88:18: fatal error: dt-bindings/iio/adc/qcom,spmi-vadc.h: No such file or directory
   88 |         #include <dt-bindings/iio/adc/qcom,spmi-vadc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.example.dtb] Error 1

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250131183242.3653595-3-jishnu.prakash@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.