linux-kernel - Re: [PATCH 4/4] microblaze: remove unnecessary system.dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJyNiUF8--wz2DsngUAuSUboq8oqZRxAzqY+iBRM7rkjQ@mail.gmail.com>
Date: Fri, 31 Jan 2025 16:25:07 -0600
From: Rob Herring <robh@...nel.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Michal Simek <monstr@...str.eu>, linux-kernel@...r.kernel.org, 
	Conor Dooley <conor+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, devicetree@...r.kernel.org
Subject: Re: [PATCH 4/4] microblaze: remove unnecessary system.dts

On Tue, Jan 14, 2025 at 12:15 PM Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> The default image linux.bin does not contain any DTB, but a separate
> system.dtb is compiled.
>
> Michal Simek clearly explained "system.dtb is really old dtb more for
> demonstration purpose and nothing else and likely it is not working on
> any existing board." [1]
>
> The system.dts is not necessary even for demonstration purposes. There
> is no need to compile out-of-tree *.dts under arch/microblaze/boot/dts/
> unless it is embedded into the kernel. Users can directly use dtc.
>
> [1]: https://lore.kernel.org/all/d2bdfbfd-3721-407f-991e-566d48392add@amd.com/
>
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
>
>  arch/microblaze/boot/dts/Makefile   |   3 +-
>  arch/microblaze/boot/dts/system.dts | 353 ----------------------------
>  2 files changed, 1 insertion(+), 355 deletions(-)
>  delete mode 100644 arch/microblaze/boot/dts/system.dts
>
> diff --git a/arch/microblaze/boot/dts/Makefile b/arch/microblaze/boot/dts/Makefile
> index 932dc7550a1b..fa0a6c0854ca 100644
> --- a/arch/microblaze/boot/dts/Makefile
> +++ b/arch/microblaze/boot/dts/Makefile
> @@ -1,8 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  #
>
> -dtb-y := system.dtb
> -
>  ifneq ($(DTB),)
>  obj-y += linked_dtb.o
>
> @@ -11,6 +9,7 @@ $(obj)/linked_dtb.o: $(obj)/system.dtb
>
>  # Generate system.dtb from $(DTB).dtb
>  ifneq ($(DTB),system)

Can't this be dropped as setting DTB=system.dtb should work if there's
not an in-tree system.dts anymore.

> +targets += system.dtb
>  $(obj)/system.dtb: $(obj)/$(DTB).dtb FORCE
>         $(call if_changed,copy)
>  endif