linux-kernel - Re: [PATCH v3 3/7] crash: Let arch decide usable memory range in reserved area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e7e371cc-cb34-4ba1-8aa5-c18ec3802d9a@linux.ibm.com>
Date: Sat, 1 Feb 2025 12:46:34 +0530
From: Sourabh Jain <sourabhjain@...ux.ibm.com>
To: Baoquan he <bhe@...hat.com>
Cc: linuxppc-dev@...ts.ozlabs.org, Andrew Morton <akpm@...ux-foundation.org>,
        Hari Bathini <hbathini@...ux.ibm.com>,
        Madhavan Srinivasan <maddy@...ux.ibm.com>,
        Mahesh Salgaonkar <mahesh@...ux.ibm.com>,
        Michael Ellerman <mpe@...erman.id.au>, kexec@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/7] crash: Let arch decide usable memory range in
 reserved area

Hello Baoquan,


On 01/02/25 09:52, Baoquan he wrote:
> On 01/31/25 at 05:08pm, Sourabh Jain wrote:
>> Although the crashkernel area is reserved, on architectures like
>> PowerPC, it is possible for the crashkernel reserved area to contain
>> components like RTAS, TCE, OPAL, etc. To avoid placing kexec segments
>> over these components, PowerPC has its own set of APIs to locate holes
>> in the crashkernel reserved area.
>>
>> Add an arch hook in the generic locate mem hole APIs so that
>> architectures can handle such special regions in the crashkernel area
>> while locating memory holes for kexec segments using generic APIs.
>> With this, a lot of redundant arch-specific code can be removed, as it
>> performs the exact same job as the generic APIs.
>>
>> To keep the generic and arch-specific changes separate, the changes
>> related to moving PowerPC to use the generic APIs and the removal of
>> PowerPC-specific APIs for memory hole allocation are done in a
>> subsequent patch titled "powerpc/crash: Use generic APIs to locate
>> memory hole for kdump.
>>
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Cc: Baoquan he <bhe@...hat.com>
>> Cc: Hari Bathini <hbathini@...ux.ibm.com>
>> Cc: Madhavan Srinivasan <maddy@...ux.ibm.com>
>> Cc: Mahesh Salgaonkar <mahesh@...ux.ibm.com>
>> Cc: Michael Ellerman <mpe@...erman.id.au>
>> Cc: kexec@...ts.infradead.org
>> Cc: linux-kernel@...r.kernel.org
>> Signed-off-by: Sourabh Jain <sourabhjain@...ux.ibm.com>
>> ---
>>   include/linux/kexec.h |  9 +++++++++
>>   kernel/kexec_file.c   | 12 ++++++++++++
>>   2 files changed, 21 insertions(+)
> LGTM,
>
> Acked-by: Baoquan He <bhe@...hat.com>

Thanks for the Ack!

- Sourabh Jain