linux-kernel - Re: [PATCH V5 4/5] iio: adc: Add support for QCOM PMIC5 Gen3 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202502011915.MIBVfCtZ-lkp@intel.com>
Date: Sat, 1 Feb 2025 18:06:21 +0800
From: kernel test robot <lkp@...el.com>
To: Jishnu Prakash <jishnu.prakash@....qualcomm.com>, jic23@...nel.org,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	agross@...nel.org, andersson@...nel.org,
	dmitry.baryshkov@...aro.org, konradybcio@...nel.org,
	daniel.lezcano@...aro.org, sboyd@...nel.org, amitk@...nel.org,
	thara.gopinath@...il.com, lee@...nel.org, rafael@...nel.org,
	subbaraman.narayanamurthy@....qualcomm.com,
	david.collins@....qualcomm.com, anjelique.melendez@....qualcomm.com,
	quic_kamalw@...cinc.com
Cc: oe-kbuild-all@...ts.linux.dev, rui.zhang@...el.com, lukasz.luba@....com,
	lars@...afoo.de, devicetree@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	cros-qcom-dts-watchers@...omium.org,
	jishnu.prakash@....qualcomm.com, quic_skakitap@...cinc.com,
	neil.armstrong@...aro.org
Subject: Re: [PATCH V5 4/5] iio: adc: Add support for QCOM PMIC5 Gen3 ADC

Hi Jishnu,

kernel test robot noticed the following build errors:

[auto build test ERROR on 5ffa57f6eecefababb8cbe327222ef171943b183]

url:    https://github.com/intel-lab-lkp/linux/commits/Jishnu-Prakash/dt-bindings-iio-adc-Move-QCOM-ADC-bindings-to-iio-adc-folder/20250201-023723
base:   5ffa57f6eecefababb8cbe327222ef171943b183
patch link:    https://lore.kernel.org/r/20250131183242.3653595-5-jishnu.prakash%40oss.qualcomm.com
patch subject: [PATCH V5 4/5] iio: adc: Add support for QCOM PMIC5 Gen3 ADC
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20250201/202502011915.MIBVfCtZ-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250201/202502011915.MIBVfCtZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502011915.MIBVfCtZ-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/iio/adc/qcom-adc5-gen3-common.c: In function 'adc5_gen3_update_dig_param':
>> drivers/iio/adc/qcom-adc5-gen3-common.c:72:18: error: implicit declaration of function 'FIELD_PREP' [-Wimplicit-function-declaration]
      72 |         *data |= FIELD_PREP(ADC5_GEN3_DIG_PARAM_CAL_SEL_MASK, prop->cal_method);
         |                  ^~~~~~~~~~


vim +/FIELD_PREP +72 drivers/iio/adc/qcom-adc5-gen3-common.c

    67	
    68	void adc5_gen3_update_dig_param(struct adc5_channel_common_prop *prop, u8 *data)
    69	{
    70		/* Update calibration select and decimation ratio select */
    71		*data &= ~(ADC5_GEN3_DIG_PARAM_CAL_SEL_MASK | ADC5_GEN3_DIG_PARAM_DEC_RATIO_SEL_MASK);
  > 72		*data |= FIELD_PREP(ADC5_GEN3_DIG_PARAM_CAL_SEL_MASK, prop->cal_method);
    73		*data |= FIELD_PREP(ADC5_GEN3_DIG_PARAM_DEC_RATIO_SEL_MASK, prop->decimation);
    74	}
    75	EXPORT_SYMBOL(adc5_gen3_update_dig_param);
    76	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki