linux-kernel - Re: [PATCH 2/4] Bluetooth: qca: add WCN3950 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13d5026c-3274-4b90-b941-22f08a8ebdc4@molgen.mpg.de>
Date: Sat, 1 Feb 2025 13:15:29 +0100
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Balakrishna Godavarthi <quic_bgodavar@...cinc.com>,
 Rocky Liao <quic_rjliao@...cinc.com>, Bjorn Andersson
 <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
 linux-bluetooth@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/4] Bluetooth: qca: add WCN3950 support

Dear Dmitry,


Thank you for the patch.

Am 01.02.25 um 10:18 schrieb Dmitry Baryshkov:
> WCN3950 is another example of the WCN39xx BT/WiFI family of chips. It
> requires different firmware files and has different current
> requirements, so add it as a separate SoC type.

Is the firmware publicly available already? (In patch 4/4 you write, it 
is, and I found it [1].) I find such information helpful in commit 
messages, and also the firmware names:

•   qca/cmbtfw12.tlv
•   qca/cmbtfw13.tlv
•   qca/cmnv12.bin
•   qca/cmnv13.bin

Do you also have a datasheet name to review the vregs?

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> ---
>   drivers/bluetooth/btqca.c   |  9 +++++++++
>   drivers/bluetooth/btqca.h   |  1 +
>   drivers/bluetooth/hci_qca.c | 25 +++++++++++++++++++++++++
>   3 files changed, 35 insertions(+)

[…]

The rest looks good.


Kind regards,

Paul


[1]: 
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=421017641e6a6ef389190ac3edf67885183f3de0