linux-kernel - Re: [PATCH v4] Weighted Interleave Auto-tuning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z55QmybX5IkuLv6Q@gourry-fedora-PF4VCD3F>
Date: Sat, 1 Feb 2025 11:49:31 -0500
From: Gregory Price <gourry@...rry.net>
To: Honggyu Kim <honggyu.km@...il.com>
Cc: Joshua Hahn <joshua.hahnjy@...il.com>, ying.huang@...ux.alibaba.com,
	rafael@...nel.org, lenb@...nel.org, gregkh@...uxfoundation.org,
	akpm@...ux-foundation.org, honggyu.kim@...com, rakie.kim@...com,
	dan.j.williams@...el.com, Jonathan.Cameron@...wei.com,
	dave.jiang@...el.com, horen.chuang@...ux.dev, hannes@...xchg.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	linux-mm@...ck.org, kernel-team@...a.com, kernel_team@...ynix.com,
	42.hyeyoo@...il.com
Subject: Re: [PATCH v4] Weighted Interleave Auto-tuning

Hi Honggyu,

On Fri, Jan 31, 2025 at 11:23:34PM +0900, Honggyu Kim wrote:
> Sorry for jumping into this discussion a bit late, but IMHO, setting a
> newly onlined node's weight to 1 can possibly make the entire weight
> ratio unbalanced.
> 

This is only the default for either:
a) Manual Mode
b) Auto Mode - when HMAT/CDAT data is missing

In manual mode, the node weight in /sys/kernel/.../nodeN is present
regardless of the online/offline state of the node - so it can be
set prior to that node being hotplugged.  Since it's in manual mode,
it's expected the administrator knows when things are coming online
and offline, and they have a clear chance to change weights such that
a 1 is never perceived.

In auto mode, the node goes "online" after HMAT/CDAT data is reported
so users will generally not perceive this default weight.

>   1. the auto mode set the weights as 10:5:1 for node{0-2}.
>   2. node2 is offlined, then recalculation makes it as 2:1 for node{0,1}.
>   3. the auto sysfs interface is set to 0 to make it manual mode.

If the user sets manual mode, they get manual mode.  If they don't
want to manually adjust weights, don't set manual mode.

We can't stop users from doing silly things

~Gregory