Message-ID: <632be2db-78d2-4249-92f0-3f60e0373172@linux.microsoft.com>
Date: Fri, 31 Jan 2025 16:11:37 -0800
From: Easwar Hariharan <eahariha@...ux.microsoft.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: cocci@...ia.fr, kernel-janitors@...r.kernel.org,
 eahariha@...ux.microsoft.com, LKML <linux-kernel@...r.kernel.org>,
 linux-block@...r.kernel.org, linux-btrfs@...r.kernel.org,
 linux-ide@...r.kernel.org, linux-nvme@...ts.infradead.org,
 linux-pm@...r.kernel.org, linux-rdma@...r.kernel.org,
 linux-scsi@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-spi@...r.kernel.org, linux-xfs@...r.kernel.org,
 ceph-devel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, ibm-acpi-devel@...ts.sourceforge.net,
 imx@...ts.linux.dev, kernel@...gutronix.de,
 linux-arm-kernel@...ts.infradead.org,
 Andrew Morton <akpm@...ux-foundation.org>, Carlos Maiolino <cem@...nel.org>,
 Chris Mason <clm@...com>, Christoph Hellwig <hch@....de>,
 Damien Le Moal <dlemoal@...nel.org>, "Darrick J. Wong" <djwong@...nel.org>,
 David Sterba <dsterba@...e.com>, Dick Kennedy <dick.kennedy@...adcom.com>,
 Dongsheng Yang <dongsheng.yang@...ystack.cn>,
 Fabio Estevam <festevam@...il.com>, Frank Li <Frank.Li@....com>,
 Hans de Goede <hdegoede@...hat.com>,
 Henrique de Moraes Holschuh <hmh@....eng.br>,
 James Bottomley <James.Bottomley@...senPartnership.com>,
 James Smart <james.smart@...adcom.com>, Jaroslav Kysela <perex@...ex.cz>,
 Jason Gunthorpe <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>,
 Josef Bacik <josef@...icpanda.com>, Julia Lawall <Julia.Lawall@...ia.fr>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Ilya Dryomov <idryomov@...il.com>,
 Kalesh Anakkur Purayil <kalesh-anakkur.purayil@...adcom.com>,
 Keith Busch <kbusch@...nel.org>, Leon Romanovsky <leon@...nel.org>,
 Mark Brown <broonie@...nel.org>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 Nicolas Palix <nicolas.palix@...g.fr>, Niklas Cassel <cassel@...nel.org>,
 Oded Gabbay <ogabbay@...nel.org>, Ricardo Ribalda <ribalda@...gle.com>,
 Sagi Grimberg <sagi@...mberg.me>, Sascha Hauer <s.hauer@...gutronix.de>,
 Sebastian Reichel <sre@...nel.org>,
 Selvin Xavier <selvin.xavier@...adcom.com>, Shawn Guo <shawnguo@...nel.org>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>, Takashi Iwai <tiwai@...e.com>,
 Victor Gambier <victor.gambier@...ia.fr>, Xiubo Li <xiubli@...hat.com>,
 Yaron Avizrat <yaron.avizrat@...el.com>,
 Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [PATCH 01/16] coccinelle: misc: secs_to_jiffies: Patch
 expressions too

On 1/30/2025 3:01 AM, Markus Elfring wrote:
>> Teach the script to suggest conversions for timeout patterns where the
>> arguments to msecs_to_jiffies() are expressions as well.
> 
> Does anything hinder to benefit any more from a source code analysis approach
> (like the following by the extended means of the semantic patch language)?
> 

Thank you, this is much more useful feedback, specifically due to the
suggested patch below. I did intend to learn about the other modes and
progressively upgrade secs_to_jiffies.cocci with them in the future once
the existing instances were resolved, to help with future code
submissions. The patch below will be super helpful in that.

As it stands, I'll fix up the current rules in v2 following your
suggestion to keep the multiplication in each line to allow Coccinelle
to use the commutativity properties and find more instances.

I'll refrain from implementing the report mode until current instances
have been fixed because of the issue we have already seen[1] with CI
builds being broken. I would not want to break a strict CI build that is
looking for coccicheck REPORT to return 0 results.

[1]:
https://lore.kernel.org/all/20250129-secs_to_jiffles-v1-1-35a5e16b9f03@chromium.org/

<snip>

Thanks,
Easwar (he/him)

Powered by blists - more mailing lists