linux-kernel - Re: [PATCH v3] cpuidle: psci: Add trace for PSCI domain idle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250202104211.2764016-1-keyz@google.com>
Date: Sun,  2 Feb 2025 18:42:11 +0800
From: Keita Morisaki <keyz@...gle.com>
To: khilman@...nel.org
Cc: aarontian@...gle.com, daniel.lezcano@...aro.org, keyz@...gle.com, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	linux-trace-kernel@...r.kernel.org, lpieralisi@...nel.org, 
	mathieu.desnoyers@...icios.com, mhiramat@...nel.org, rafael@...nel.org, 
	rostedt@...dmis.org, sudeep.holla@....com, yimingtseng@...gle.com
Subject: Re: [PATCH v3] cpuidle: psci: Add trace for PSCI domain idle

> Tested-by: Kevin Hilman <khilman@...libre.com>
>
> I've been using some local trace_printk() to do exactly this, so I fully
> support having some official tracepoints here.
>
> For my local hacks, I was trackin the state index as well as the state
> value since for quick debug, I find the index to more human readable
> than the state value, which I have to compare with the
> arm,psci-suspend-pararm from the DT.
>
> Anyways, thanks for submitting this!
>
> Kevin

Thank you so much for the endorsement.
Showing the index sounds like a good idea, although it should be done in a
different layer (probably in the GenPD governor or cpuidle-psci driver?) because
idx here should be the different index from the one we're looking for.
I will keep my patch as it is just for now. Thank you for the idea!