linux-kernel - Re: [PATCH v4 3/4] drm/vc4: hdmi: Use drm_atomic_helper_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250203172044.74967850@bootlin.com>
Date: Mon, 3 Feb 2025 17:20:44 +0100
From: Herve Codina <herve.codina@...tlin.com>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Alexander Stein <alexander.stein@...tq-group.com>, Andrzej Hajda
 <andrzej.hajda@...el.com>, Neil Armstrong <neil.armstrong@...aro.org>,
 Robert Foss <rfoss@...nel.org>, Laurent Pinchart
 <Laurent.pinchart@...asonboard.com>, Jonas Karlman <jonas@...boo.se>,
 Jernej Skrabec <jernej.skrabec@...il.com>, David Airlie
 <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Maíra Canal <mcanal@...lia.com>, Raspberry Pi Kernel
 Maintenance <kernel-list@...pberrypi.com>, Marek Vasut <marex@...x.de>,
 dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Louis Chauvet <louis.chauvet@...tlin.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v4 3/4] drm/vc4: hdmi: Use
 drm_atomic_helper_reset_crtc()

Hi Dmitry,

On Mon, 3 Feb 2025 17:56:46 +0200
Dmitry Baryshkov <dmitry.baryshkov@...aro.org> wrote:

> On Mon, Feb 03, 2025 at 03:58:22PM +0100, Herve Codina wrote:
> > The current code uses a the reset_pipe() local function to reset the
> > CRTC outputs.
> > 
> > drm_atomic_helper_reset_crtc() has been introduced recently and it
> > performs exact same operations.
> > 
> > In order to avoid code duplication, use the new helper instead of the
> > local function.
> > 
> > Signed-off-by: Herve Codina <herve.codina@...tlin.com>
> > ---
> >  drivers/gpu/drm/vc4/vc4_hdmi.c | 30 +-----------------------------
> >  1 file changed, 1 insertion(+), 29 deletions(-)
> >   
> 
> Acked-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 

I messed me up in this v4. It doesn't apply on top of v6.14-rc1.

I already sent a v5 to fix that.

Can you add your tag on the v5?

Of course, I will add them myself if a v6 is needed.

I am sorry about my mistake.

Apologies,
Hervé

-- 
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com