linux-kernel - Re: [PATCH v7 4/7] arm64: dts: qcom: ipq9574: Reorder reg and reg-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f7551daa-cce5-47b3-873f-21b9c5026ed2@kernel.org>
Date: Mon, 3 Feb 2025 17:27:32 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
 Varadarajan Narayanan <quic_varada@...cinc.com>, bhelgaas@...gle.com,
 lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, vkoul@...nel.org,
 kishon@...nel.org, andersson@...nel.org, konradybcio@...nel.org,
 p.zabel@...gutronix.de, dmitry.baryshkov@...aro.org,
 quic_nsekar@...cinc.com, linux-arm-msm@...r.kernel.org,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Subject: Re: [PATCH v7 4/7] arm64: dts: qcom: ipq9574: Reorder reg and
 reg-names

On 27/01/2025 11:33, Konrad Dybcio wrote:
> On 22.01.2025 7:34 AM, Varadarajan Narayanan wrote:
>> The 'reg' & 'reg-names' constraints used in the bindings and dtsi
>> are different resulting in dt_bindings_check errors. Re-order
>> them to address following errors.
>>
>> 	arch/arm64/boot/dts/qcom/ipq9574-rdp449.dtb: pcie@...00000: reg-names:0: 'parf' was expected
>>
>> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
>> ---
>>  arch/arm64/boot/dts/qcom/ipq9574.dtsi | 52 +++++++++++++++++----------
>>  1 file changed, 34 insertions(+), 18 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> index 942290028972..d27c55c7f6e4 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> @@ -876,12 +876,16 @@ frame@...8000 {
>>  
>>  		pcie1: pcie@...00000 {
>>  			compatible = "qcom,pcie-ipq9574";
>> -			reg =  <0x10000000 0xf1d>,
>> -			       <0x10000f20 0xa8>,
>> -			       <0x10001000 0x1000>,
>> -			       <0x000f8000 0x4000>,
>> -			       <0x10100000 0x1000>;
>> -			reg-names = "dbi", "elbi", "atu", "parf", "config";
>> +			reg = <0x000f8000 0x4000>,
>> +			      <0x10000000 0xf1d>,
>> +			      <0x10000f20 0xa8>,
>> +			      <0x10001000 0x1000>,
>> +			      <0x10100000 0x1000>;
> 
> The unit address (the one after '@' in the node definition) is supposed to
> match the first 'reg' entry. So you need to update that and reorder the
> nodes accordingly.
> 
> Krzysztof, is this acceptable to pick up given the reg entries are being
> shuffled around?

Uh, no, this leads to warnings.

BTW, I really hope tools were being used to spot that, not maintainers
like you or me.

But this is anyway old patchset whose newer version was rejected. There
is just to many wrong things happening in the process - now one more:
not running standard tests on this.

Best regards,
Krzysztof