linux-kernel - Re: [PATCH] usb: phy: mxs: silence EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a0f8cd9-fe3e-4f07-bf9e-e1b877ffda0a@wanadoo.fr>
Date: Mon, 3 Feb 2025 07:19:47 +0100
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: dominique.martinet@...ark-techno.com
Cc: festevam@...il.com, gregkh@...uxfoundation.org, imx@...ts.linux.dev,
 kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 s.hauer@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH] usb: phy: mxs: silence EPROBE_DEFER error on boot

Le 03/02/2025 à 07:09, Dominique Martinet a écrit :
> Use dev_err_probe to silence EPROBE_DEFER error on boot on i.MX8ULP:
> [    0.127301] mxs_phy 29910000.usb-phy: can't get the clock, err=-517
> 
> Signed-off-by: Dominique Martinet <dominique.martinet-9u97MdVgWv6RbxiC3EKwHAC/G2K4zDHf@...lic.gmane.org>
> ---
>   drivers/usb/phy/phy-mxs-usb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> index 7490f1798b461c39c29bb74e1e57e0a4adce2bd7..dd2b4a5633934e257e792bbd61d6748304b5e679 100644
> --- a/drivers/usb/phy/phy-mxs-usb.c
> +++ b/drivers/usb/phy/phy-mxs-usb.c
> @@ -770,9 +770,8 @@ static int mxs_phy_probe(struct platform_device *pdev)
>   
>   	clk = devm_clk_get(&pdev->dev, NULL);
>   	if (IS_ERR(clk)) {
> -		dev_err(&pdev->dev,
> +		return dev_err_probe(&pdev->dev, PTR_ERR(clk),
>   			"can't get the clock, err=%ld", PTR_ERR(clk));

, err=%ld", PTR_ERR(clk) should be removed now.

The error code will already be added in the message in a human readable way.

Alignment could also be adjusted so that "can't... is still under the (.

CJ

> -		return PTR_ERR(clk);
>   	}
>   
>   	mxs_phy = devm_kzalloc(&pdev->dev, sizeof(*mxs_phy), GFP_KERNEL);
> 
> ---
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
> change-id: 20250203-defer_usb2-ee26f66a01ad
> 
> Best regards,