linux-kernel - Re: [PATCH 1/2] usb: typec: thunderbolt: Fix loops that iterate TYPEC_PLUG_SOP_P and TYPEC_PLUG_SOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6D0j3EphmwMoWj3@google.com>
Date: Mon, 3 Feb 2025 16:53:35 +0000
From: Benson Leung <bleung@...gle.com>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: Benson Leung <bleung@...omium.org>, heikki.krogerus@...ux.intel.com,
	abhishekpandit@...omium.org, dan.carpenter@...aro.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	akuchynski@...gle.com, ukaszb@...omium.org
Subject: Re: [PATCH 1/2] usb: typec: thunderbolt: Fix loops that iterate
 TYPEC_PLUG_SOP_P and TYPEC_PLUG_SOP_PP

Hi Greg,

On Mon, Feb 03, 2025 at 04:18:28PM +0100, Greg KH wrote:
> On Fri, Jan 24, 2025 at 07:40:23PM +0000, Benson Leung wrote:
> > Fixes these Smatch static checker warnings:
> > drivers/usb/typec/altmodes/thunderbolt.c:116 tbt_altmode_work() warn: why is zero skipped 'i'
> > drivers/usb/typec/altmodes/thunderbolt.c:147 tbt_enter_modes_ordered() warn: why is zero skipped 'i'
> > drivers/usb/typec/altmodes/thunderbolt.c:328 tbt_altmode_remove() warn: why is zero skipped 'i'
> > 
> > Fixes: 100e25738659 ("usb: typec: Add driver for Thunderbolt 3 Alternate Mode")
> > 
> > Signed-off-by: Benson Leung <bleung@...omium.org>
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  drivers/usb/typec/altmodes/thunderbolt.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Please always use 'git send-email' or if not, manually thread your
> patches so they all show up together as a series.  These are both
> individual and as such, don't play nice with tools.

Sorry about that. I still need to set up my git-send-email workflow on this new
cloud workstation, and I'll get that rectified for next time.

> 
> I'll try to manually handle them, but you owe me...

Thanks! I'll definitely owe you one.

> 
> thanks,
> 
> greg k-h

Benson

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)