linux-kernel - Re: [PATCH] perf: Always feature test reallocarray

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <173860935114.138188.17102084306556571882.b4-ty@kernel.org>
Date: Mon, 03 Feb 2025 11:02:31 -0800
From: Namhyung Kim <namhyung@...nel.org>
To: linux-perf-users@...r.kernel.org, James Clark <james.clark@...aro.org>
Cc: Ali Utku Selen <ali.utku.selen@....com>, 
 Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
 Arnaldo Carvalho de Melo <acme@...nel.org>, 
 Mark Rutland <mark.rutland@....com>, 
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>, 
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>, 
 Adrian Hunter <adrian.hunter@...el.com>, 
 "Liang, Kan" <kan.liang@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf: Always feature test reallocarray

On Wed, 29 Jan 2025 15:44:05 +0000, James Clark wrote:
> This is also used in util/comm.c now, so instead of selectively doing
> the feature test, always do it. If it's ever used anywhere else it's
> less likely to cause another build failure.
> 
> This doesn't remove the need to manually include libc_compat.h, and
> missing that will still cause an error for glibc < 2.26. There isn't a
> way to fix that without poisoning reallocarray like libbpf did, but that
> has other downsides like making memory debugging tools less useful. So
> for Perf keep it like this and we'll have to fix up any missed includes.
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung